This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
draft: optional binds #1605
Draft
draft: optional binds #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidpr
approved these changes
Mar 20, 2023
Comment on lines
+133
to
+137
| :code:`--bind-path={PATH[:PREFIX}` | ||
| Add file from path to to ch-run optional default run-time binds. | ||
|
|
||
| * Path to host file. Optionally bind at prefix if set; otherwise, | ||
| :code:`/usr/local/lib` |
There was a problem hiding this comment.
I'm pretty sure this (i.e., arbitrary default bind-mounts) can be implemented, but I'm not sure offhand how to do it. If there's not an immediate use case, maybe leave this for future work?
Comment on lines
+127
to
+128
| Optional bind selection: :code:`--bind-FOO` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
I think these will want to be spelled --enable-bind-FOO, because --enable gets special treatment in Autotools.
Comment on lines
+124
to
+125
| Some dependencies can be specified as follows. Note only some of these support | ||
| :code:`--with-FOO=no`, as listed. |
| By default, :code:`ch-run` binds the minimal number mount points needed to run. | ||
| You can add more files with: | ||
|
|
||
| :code:`--bind-path={PATH[:PREFIX}` |
There was a problem hiding this comment.
Suggested change
| :code:`--bind-path={PATH[:PREFIX}` | |
| :code:`--bind-path={HOST_PATH[:IMAGE_PATH]}` |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.