Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add lit-html enabled graph #4331

Open
wants to merge 1 commit into
base: candidate-3.x.x
Choose a base branch
from
Open

feat: Add lit-html enabled graph #4331

wants to merge 1 commit into from

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 23, 2025 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 23, 2025 16:00
@GordonSmith
feat: Add lit-html enabled graph
726a087 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
jeclrsg
jeclrsg reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith Didn't notice anything except those test failures that GH pointed out

packages/graph/src/graph2/graphReact.ts
@@ -76,9 +76,9 @@ export class Graph2 extends GraphReactT<ISubgraph, IVertex, IEdge> {
this._centroidFilter.update(this.centroidColor());
}
}
Graph2.prototype._class += " graph_Graph2";
GraphReact.prototype._class += " graph_React";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be graph_GraphReact? Github Actions is noting some test failures below.

packages/graph/src/graph2/graphHtmlT.ts

constructor(subgraphRenderer: Component<SG>, vertexRenderer: Component<V>, edgeRenderer: Component<E>) {
super(adapter(subgraphRenderer), adapter(vertexRenderer), adapter(edgeRenderer));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And is the other test failure because there isn't a render function in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg