Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no more existing devices and templates from internal cache #99

Conversation

mib1185
Copy link
Collaborator

@mib1185 mib1185 commented Apr 1, 2024

no more existing devices and templates will be removed from internal caches self._devices and self._templates.
With this we will be able to detect if a device or template has been removed and do necessary steps in consuming application (eq. in homeassistant)

@coveralls
Copy link

coveralls commented Apr 1, 2024

Coverage Status

coverage: 94.592% (+0.3%) from 94.295%
when pulling f85774e on mib1185:remove-no-more-existing-devices-and-templates-from-internal-cache
into dbd1442 on hthiery:master.

@mib1185 mib1185 requested a review from hthiery April 1, 2024 16:43
Copy link
Owner

@hthiery hthiery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mib1185
Copy link
Collaborator Author

mib1185 commented Apr 17, 2024

Hi @hthiery do you mind to enable "Squash and Merge" for this repo? So we would be able to squash all commits of this PR into one merge-commit into the master branch, without the need to do this manually in this PR

@mib1185 mib1185 force-pushed the remove-no-more-existing-devices-and-templates-from-internal-cache branch 4 times, most recently from b003dd3 to d154f39 Compare April 20, 2024 21:27
@mib1185 mib1185 force-pushed the remove-no-more-existing-devices-and-templates-from-internal-cache branch from d154f39 to 45a84fe Compare April 20, 2024 21:31
@mib1185 mib1185 merged commit bd1b468 into hthiery:master Apr 20, 2024
11 checks passed
@mib1185 mib1185 deleted the remove-no-more-existing-devices-and-templates-from-internal-cache branch April 20, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants