Add class ensuring for WidgetTemplate #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone raised an issue with custom widgets and builder files, GeopJr/ultimate-gtk4-crystal-guide#9 (comment)
The issue is that we need to ensure that the class exists for GTK to bind them. I see gtk-rs does it on template_child, but in that issue's case, the user does not use template_child. This PR adds the following to WidgetTemplate:
@[Gtk::UiTemplate(resource: "/dev/ui/main.ui", ensure_classes: {MyButton})]and calls
LibGObject.g_type_ensureon every ensure_classes child