Refactor docs for the ROS Equipment entry #5
+220
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delihus
requested changes
Jan 10, 2025
Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com>
delihus
requested changes
Jan 23, 2025
|
|
||
| Get a reference file from for Panther: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
I think it is overkill. Let's add the volume to the /config/crsf_teleop_panther.yaml and describe how to change it to lynx. So:
If you use Lynx change in compose.yaml /config/crsf_teleop_panther.yaml to /config/crsf_teleop_lynx.yaml it is much easier than coping the files.
| @@ -10,7 +10,8 @@ services: | |||
| - RMW_IMPLEMENTATION=${RMW_IMPLEMENTATION:-rmw_cyclonedds_cpp} | |||
| - ROS_DOMAIN_ID=${ROS_DOMAIN_ID:-0} | |||
| - ROBOT_MODEL_NAME=${ROBOT_MODEL_NAME:-panther} | |||
| - ROBOT_NAMESPACE=${ROBOT_NAMESPACE:-panther} | |||
There was a problem hiding this comment.
Add a volume for configuration directly and create the compose.yaml for panther.
Use params_file launch argument
delihus
requested changes
Jan 23, 2025
| /**: | ||
| crsf_teleop: | ||
| ros__parameters: | ||
| port: /dev/ttyUSB0 |
There was a problem hiding this comment.
Suggested change
| port: /dev/ttyUSB0 | |
| port: /dev/ttyUSBPAD |
and let's change this file to default_params.yaml
There was a problem hiding this comment.
I have commited this file by mistake, deleting it
Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com>
Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS_API.mdcontaining text from oldREADME.mdREADME.mdto serve as a demo / usage guide