Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use AudioGraph to output and process audio #363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Apr 22, 2024

Use AudioGraph to handle audio output from VLC using audio callbacks. This change allows us to potentially extract audio data for additional post-processing and filtering, or external use cases such as audio visualizations.

As the AudioFrameInputNode has a limited buffer, a circular buffer is used to transport and package audio data from VLC into audio frames. VLC and AudioGraph run on separate threads, interacting with the buffer asynchronously. Due to the complex nature of the producer-consumer model, some audio issues can occur, including delay, click, or hitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant