-
Notifications
You must be signed in to change notification settings - Fork 180
Fixes #213
base: master
Are you sure you want to change the base?
Fixes #213
Conversation
I can't sign this on behalf of my employer. But these are very simple fixes. They are probably too short to be copyrightable. |
I'm informed that my employer has signed the CLA, so I think this is good to go now. |
Individual CLA is enforced and if the CLA checks fail we cannot accept the contribution. |
Closing PR due to CLA compliance. Please reopen once the individual CLA is signed. |
I've signed the individual CLA on behalf of my employer. But it still says "CLA not signed yet" above. I've tried clicking the "recheck" link. @rvema do you understand what's happening? |
@balnbibarbi we have not witnessed any issues with CLA however if your gitconfig is not configured properly say email is not associated with commit it may cause an issue. Please create a new PR with the same changes and try again. |
It's suddenly decided I've signed the CLA. I didn't do anything! Never mind. |
@balnbibarbi can you update your branch? |
WhiteSource says I've introduced 7 new vulnerabilities in this branch. That's surprising, given that I didn't change any runtime dependencies. I just changed one compile-time dependency (the jacoco maven plugin). I think either I or WhiteSource have got confused somehow? We can fix these vulnerabilities by upgrading to a new minor version of Spring Boot. The current 1.5.22 is the latest in the 1.5.x series, so we'd have to upgrade to 1.6.x at minimum. We could even upgrade to the latest 2.6.x. |
The externalised config change is intended to be backward compatible. I hope I didn't miss anything?
The other two changes are trivial fixes.