Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Fixes #213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes #213

wants to merge 5 commits into from

Conversation

balnbibarbi
Copy link

The externalised config change is intended to be backward compatible. I hope I didn't miss anything?
The other two changes are trivial fixes.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2021

CLA assistant check
All committers have signed the CLA.

@balnbibarbi
Copy link
Author

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

I can't sign this on behalf of my employer. But these are very simple fixes. They are probably too short to be copyrightable.

@balnbibarbi
Copy link
Author

I'm informed that my employer has signed the CLA, so I think this is good to go now.

@rvema
Copy link
Contributor

rvema commented Mar 28, 2022

Individual CLA is enforced and if the CLA checks fail we cannot accept the contribution.

@rvema
Copy link
Contributor

rvema commented Mar 28, 2022

Closing PR due to CLA compliance. Please reopen once the individual CLA is signed.

@rvema rvema closed this Mar 28, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 28, 2022
@balnbibarbi
Copy link
Author

I've signed the individual CLA on behalf of my employer. But it still says "CLA not signed yet" above. I've tried clicking the "recheck" link. @rvema do you understand what's happening?
Also, I can't see a way to re-open this PR.

@rvema
Copy link
Contributor

rvema commented Mar 29, 2022

@balnbibarbi we have not witnessed any issues with CLA however if your gitconfig is not configured properly say email is not associated with commit it may cause an issue. Please create a new PR with the same changes and try again.

@balnbibarbi
Copy link
Author

It's suddenly decided I've signed the CLA. I didn't do anything! Never mind.
Can you please re-open? Then I will fix the merge conflicts.

@rvema rvema reopened this Mar 30, 2022
@rvema
Copy link
Contributor

rvema commented Mar 30, 2022

@balnbibarbi can you update your branch?

@balnbibarbi
Copy link
Author

balnbibarbi commented Apr 1, 2022

WhiteSource says I've introduced 7 new vulnerabilities in this branch. That's surprising, given that I didn't change any runtime dependencies. I just changed one compile-time dependency (the jacoco maven plugin). I think either I or WhiteSource have got confused somehow?

We can fix these vulnerabilities by upgrading to a new minor version of Spring Boot. The current 1.5.22 is the latest in the 1.5.x series, so we'd have to upgrade to 1.6.x at minimum. We could even upgrade to the latest 2.6.x.
In any case, upgrading Spring Boot is a somewhat disruptive change. If we decide to do it we should do it on a separate branch, not on this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants