feat(client): http_connector supports set_interface
#2484
Conversation
kolapapa
changed the title
SO_BINDTODEVICE
src/client/connect/http.rs
Outdated
| /// [VRF]: https://www.kernel.org/doc/Documentation/networking/vrf.txt | ||
| #[cfg(any(target_os = "android", target_os = "fuchsia", target_os = "linux"))] | ||
| #[inline] | ||
| pub fn bind_device<S: ToString>(&mut self, interface: S) -> &mut Self { |
There was a problem hiding this comment.
How about the name set_interface?
There was a problem hiding this comment.
Also, I'd probably say the generic should be S: Into<String>, since otherwise set_interface(format("eth{}", num)) will make a string with format!, and then copy thanks to ToString.
src/client/connect/http.rs
Outdated
| @@ -612,6 +633,14 @@ fn connect( | |||
| ) | |||
| .map_err(ConnectError::m("tcp bind local error"))?; | |||
|
|
|||
| #[cfg(any(target_os = "android", target_os = "fuchsia", target_os = "linux"))] | |||
| // That this only works for some socket types, particularly AF_INET sockets. | |||
| if config.local_address_ipv6.is_none() && config.interface.is_some() { | |||
There was a problem hiding this comment.
Why only if the ipv6 address is none? What if the ipv4 address is some? What if ipv6 is some?
There was a problem hiding this comment.
Sorry, I mistakenly thought that IPv6 does not support SO_BINDTODEVICE operation. Later, I tried, is feasible.
kolapapa
changed the title
set_interface
|
@kolapapa is there a reason this was closed? I'd like to make use of this change, so would be keen to get this merged. |
|
(I've opened #3076 which duplicates this, but would be happy for either to be merged.) |
In my scenario, I need to detect the network stability of multiple interfaces at the same time, including ICMP, HTTP, etc.
The
bind_device()ofsocket2's crate meets the requirement of specific interface inICMP(ping). ButHTTPrelated, I use thereqwestcrate, but I can't usereqwestto bind a specific interface to achieve the flow in and out through a specific exit.And now, I need to do upload and download, HTTP quality detection and other functions at present. If I want to achieve my goal by supporting
bind_device(), please help review it. I can't help you.