Skip to content

Commit

Permalink
ci(actionlint): stop wiping workflow files that used to fail linting
Browse files Browse the repository at this point in the history
1. A large chunk of the workflow files used to have problems in the hundreds
but this no longer appear to be the case so we can add them back to the
list of linted files.
2. Also fixed on linter warning with the docker login action being outdated.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Jul 26, 2024
1 parent 2cae1b1 commit 9c7ea66
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/actionlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,15 @@ jobs:
# npm ERR! this command with --force or --legacy-peer-deps
# npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
- name: wipe_non_yaml_sources
run: rm -rf packages/ examples/ extensions/ package.json .github/workflows/test_weaver*.yaml .github/workflows/weaver_deploy*.yml weaver/
run: rm -rf packages/ examples/ extensions/ package.json weaver/

- name: actionlint
id: actionlint
uses: raven-actions/actionlint@v2
uses: raven-actions/actionlint@v2.0.0
with:
version: 1.6.27
version: 1.7.1
cache: true
files: ".github/workflows/!(weaver)*.yml, .github/workflows/!(weaver)*.yaml"

- name: actionlint_summary
if: ${{ steps.actionlint.outputs.exit-code != 0 }} # example usage, do echo only when actionlint action failed
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/weaver_deploy_go-pkgs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ jobs:
- uses: actions/checkout@v4.1.1

- name: Login to GitHub Container Registry
uses: docker/login-action@v1
uses: docker/login-action@v3.3.0
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down

0 comments on commit 9c7ea66

Please sign in to comment.