feat(cactus-connector-ethereum): add RunTransactionV1Exchange to share receipt data #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelAPB
requested review from
petermetz,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
This was referenced Nov 15, 2024
|
@petermetz are we good to merge this? |
|
@RafaelAPB It looks good to be, but you have to fix the linter failures. A handy trick to get to it faster is to use the browser's text search (CTRL+F) and then type |
outSH
requested changes
Nov 29, 2024
...lugin-ledger-connector-ethereum/src/main/typescript/web-services/watch-blocks-v1-endpoint.ts
Outdated
Show resolved
Hide resolved
RafaelAPB
force-pushed
the
satp-dev-fixup-connector-ethereum
branch
from
b05d1ed to
b013cc2
Compare
outSH
approved these changes
Dec 5, 2024
|
The |
…e receipt data Also improves watch blocks Authored-by: Bruno Mateus <brumat315@gmail.com> Co-authored-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt> Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>
petermetz
force-pushed
the
satp-dev-fixup-connector-ethereum
branch
from
b013cc2 to
8f4ed85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves watch blocks
Authored-by: Bruno Mateus brumat315@gmail.com
Co-authored-by: Rafael Belchior rafael.belchior@tecnico.ulisboa.pt
Signed-off-by: Rafael Belchior rafael.belchior@tecnico.ulisboa.pt
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.