This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
WIP: Upgrade to support latest node LTS and Typescript #126
Open
NoahMarconi
wants to merge
23
commits into
hyperledger-labs:develop
Choose a base branch
from
NoahMarconi:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Diego Barahona <diestrin@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
… strict mode Signed-off-by: Pratik <pratikc@live.co.uk> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: JonathanDe <jonathand9295@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: JonathanDe <jdominguezc26@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: JonathanDe <jdominguezc26@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: JonathanDe <jdominguezc26@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: JonathanDe <jdominguezc26@gmail.com> Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Signed-off-by: Noah Marconi <noah.marconi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Convector?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...