Skip to content

Commit

Permalink
Update PRs (#5453)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hyperledger-bot
hyperledger-bot authored Nov 17, 2023
1 parent 25b3d84 commit 110890f
Show file tree
Hide file tree
Showing 7 changed files with 78 additions and 213 deletions.
108 changes: 0 additions & 108 deletions pull-requests/hyperledger-labs/open-enterprise-agent.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -336,111 +336,3 @@ Fixes ATL-3320
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/open-enterprise-agent/pull/784" class=".btn">#784</a>
</td>
<td>
<b>
chore(castor): clean up sonarcloud issues and unused configurations
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">castor</span><span class="chip">prism-agent</span><span class="chip">infra</span>
</td>
<td>
# Overview
<!-- What this PR does, and why is needed, a useful description is expected, and relevant tickets should be mentioned -->

Partially fixes ATL-5374. Clean up some warning from sonarcloud analysis and remove unused configurations.

## Checklist

### My PR contains...
* [x] No code changes (changes to documentation, CI, metadata, etc.)
* [ ] Bug fixes (non-breaking change which fixes an issue)
* [ ] Improvements (misc. changes to existing features)
* [ ] Features (non-breaking change which adds functionality)

### My changes...
* [ ] are breaking changes
* [x] are not breaking changes
* [ ] If yes to above: I have updated the documentation accordingly

### Documentation
* [ ] My changes do not require a change to the project documentation
* [ ] My changes require a change to the project documentation
* [ ] If yes to above: I have updated the documentation accordingly

### Tests
* [ ] My changes can not or do not need to be tested
* [ ] My changes can and should be tested by unit and/or integration tests
* [ ] If yes to above: I have added tests to cover my changes
* [ ] If yes to above: I have taken care to cover edge cases in my tests

</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-10 10:19:34 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/open-enterprise-agent/pull/783" class=".btn">#783</a>
</td>
<td>
<b>
fix(prism-agent): more descriptive error response for validateDID in issue flow
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">castor</span><span class="chip">prism-agent</span>
</td>
<td>
# Overview
<!-- What this PR does, and why is needed, a useful description is expected, and relevant tickets should be mentioned -->

Fixes ATL-6156

## Checklist

### My PR contains...
* [ ] No code changes (changes to documentation, CI, metadata, etc.)
* [x] Bug fixes (non-breaking change which fixes an issue)
* [ ] Improvements (misc. changes to existing features)
* [ ] Features (non-breaking change which adds functionality)

### My changes...
* [ ] are breaking changes
* [x] are not breaking changes
* [ ] If yes to above: I have updated the documentation accordingly

### Documentation
* [x] My changes do not require a change to the project documentation
* [ ] My changes require a change to the project documentation
* [ ] If yes to above: I have updated the documentation accordingly

### Tests
* [ ] My changes can not or do not need to be tested
* [ ] My changes can and should be tested by unit and/or integration tests
* [ ] If yes to above: I have added tests to cover my changes
* [ ] If yes to above: I have taken care to cover edge cases in my tests

</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-10 08:11:00 +0000 UTC
</div>
</div>

39 changes: 39 additions & 0 deletions pull-requests/hyperledger/aries-cloudagent-python.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,45 @@ permalink: /pull-requests/hyperledger/aries-cloudagent-python
# aries-cloudagent-python <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger/aries-cloudagent-python){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/aries-cloudagent-python/pull/2612" class=".btn">#2612</a>
</td>
<td>
<b>
:bug: fix wallet_update when only `extra_settings` requested
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
Minor bug fix: `wallet_update` has a condition:

```py
if all(
v is None for v in (wallet_webhook_urls, wallet_dispatch_type, label, image_url)
):
raise web.HTTPBadRequest(reason="At least one parameter is required.")
```

This ignores the newly added `extra_settings`, and so trying to update a wallet with only `extra_settings` in the request raises a faulty Bad Request: "At least one parameter is required."

This PR simply adds `extra_settings` to the list of possible parameters.

Edit: I moved the default value of `extra_settings` to be set in the `get_extra_settings_dict_per_tenant` call. If `extra_settings` defaults to `{}` immediately, then the `v is None` check for `extra_settings` is never True.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-17 10:13:37 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand Down
36 changes: 35 additions & 1 deletion pull-requests/hyperledger/besu.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,39 @@ permalink: /pull-requests/hyperledger/besu
# besu <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger/besu){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6181" class=".btn">#6181</a>
</td>
<td>
<b>
just test
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description

## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-17 12:17:05 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand All @@ -27,7 +60,8 @@ permalink: /pull-requests/hyperledger/besu
</td>
<td>
in low peer count networks, be more lenient with timeout disconnections
in low peer count networks, be more lenient with timeout and useless response disconnects
Also reset all timeouts not just the specific messageCode
</td>
</tr>
</table>
Expand Down
47 changes: 0 additions & 47 deletions pull-requests/hyperledger/cacti.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1851,50 +1851,3 @@ For rebasing and squashing, here's a [must read guide](https://github.com/servo/
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/cacti/pull/2870" class=".btn">#2870</a>
</td>
<td>
<b>
ci: add container scanning to default checks
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
**Trivy** is a cutting-edge security tool designed to enhance the safety of containerized applications by conducting thorough vulnerability assessments. Specifically developed for scanning container images, ranging from low-severity issues to critical threats. It employs an intelligent rating system to categorize vulnerabilities based on their severity levels, ensuring that high to critical vulnerabilities are given special attention. Upon detecting vulnerabilities that fall within this elevated range, Trivy will throw an error.

By integrating Trivy into our deployment pipeline, we can proactively mitigate security risks and enhance the resilience of our repository.

Fixes hyperledger#1876

Depends On: hyperledger#2865
Depends On: hyperledger#2864
Depends On: hyperledger#2863
Depends On: hyperledger#2862

**Pull Request Requirements**
- [x] Rebased onto `upstream/main` branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
- [x] Have git sign off at the end of commit message to avoid being marked red. You can add `-s` flag when using `git commit` command. You may refer to this [link](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) for more information.
- [x] Follow the Commit Linting specification. You may refer to this [link](https://www.conventionalcommits.org/en/v1.0.0-beta.4/#specification) for more information.

**Character Limit**
- [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

**A Must Read for Beginners**
For rebasing and squashing, here's a [must read guide](https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing) for beginners.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-10 06:27:06 +0000 UTC
</div>
</div>

26 changes: 0 additions & 26 deletions pull-requests/hyperledger/iroha-java.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,3 @@ permalink: /pull-requests/hyperledger/iroha-java
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/iroha-java/pull/387" class=".btn">#387</a>
</td>
<td>
<b>
multi signature transaction
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<nil>
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-10 09:16:39 +0000 UTC
</div>
</div>

27 changes: 0 additions & 27 deletions pull-requests/hyperledger/solang.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,30 +114,3 @@ This PR adds pragmas to the ast and we test it with a graphviz dot file.
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/solang/pull/1592" class=".btn">#1592</a>
</td>
<td>
<b>
Improve overloaded function call diagnostics
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
Fixes: https://github.com/hyperledger/solang/issues/1534
Fixes: https://github.com/hyperledger/solang/issues/707
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-10 09:15:26 +0000 UTC
</div>
</div>

8 changes: 4 additions & 4 deletions trending/recent-prs.md
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@

[6181](https://github.com/hyperledger/besu/pull/6181) just test

[2612](https://github.com/hyperledger/aries-cloudagent-python/pull/2612) :bug: fix wallet_update when only `extra_settings` requested

[6179](https://github.com/hyperledger/besu/pull/6179) Stretch timeout when low peer count

[2611](https://github.com/hyperledger/aries-cloudagent-python/pull/2611) feat: support resolving did:peer:1 received in did exchange

[2609](https://github.com/hyperledger/aries-cloudagent-python/pull/2609) fix: more resilient checks in verify signed attachments

[1448](https://github.com/hyperledger/besu-docs/pull/1448) Bump got, @docusaurus/core, @docusaurus/plugin-client-redirects, @docusaurus/plugin-content-docs, @docusaurus/plugin-google-gtag, @docusaurus/plugin-google-tag-manager, @docusaurus/preset-classic, @docusaurus/theme-common, @easyops-cn/docusaurus-search-local and redocusaurus

[1447](https://github.com/hyperledger/besu-docs/pull/1447) Bump trim, @docusaurus/core, @docusaurus/plugin-client-redirects, @docusaurus/plugin-content-docs, @docusaurus/plugin-google-gtag, @docusaurus/plugin-google-tag-manager, @docusaurus/preset-classic, @docusaurus/theme-common, @easyops-cn/docusaurus-search-local and redocusaurus


[See more >>>](https://start-here.hyperledger.org/pull-requests)

0 comments on commit 110890f

Please sign in to comment.