Skip to content

Commit

Permalink
Update PRs (#5369)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hyperledger-bot
hyperledger-bot authored Nov 1, 2023
1 parent ee11c10 commit 2c2b6f6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 264 deletions.
144 changes: 0 additions & 144 deletions pull-requests/hyperledger/besu.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -145,147 +145,3 @@ Bump 23.10.1-RC to 23.10.1 on release branch
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6080" class=".btn">#6080</a>
</td>
<td>
<b>
Implement miner_setMinPriorityFee and miner_getMinPriorityFee
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">doc-change-required</span>
</td>
<td>
## PR description
Built on top of https://github.com/fab-10/besu/tree/min-priority-fee, which adds `--min-priority-fee` CLI option

Adds two new JsonRPC methods:

- miner_setMinPriorityFee - Sets the value of `miningParameters.minPriorityFeePerGas`
- miner_getMinPriorityFee - Returns the current value of `miningParameters.minPriorityFeePerGas`

This PR does not add the transactionSelector based on `minPriorityFeePerGas`. It will be added in a different PR

Examples:

Example:
Request
`{"jsonrpc":"2.0","id":1,"method":"miner_setMinPriorityFee","params":[1]}`
Response:
```
{
"jsonrpc": "2.0",
"id": 1,
"result": true
}
```
Invalid request:
` {"jsonrpc":"2.0","id":1,"method":"miner_setMinPriorityFee","params":[-1]}
`Response:
```
{
"jsonrpc": "2.0",
"id": 1,
"result": false
}
```
Get method:
` {"jsonrpc":"2.0","id":1,"method":"miner_getMinPriorityFee","params":[]}
`Response:
```
{
"jsonrpc": "2.0",
"id": 1,
"result": 7
}
```




</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-24 22:53:48 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6079" class=".btn">#6079</a>
</td>
<td>
<b>
Force tx replacement price bump to zero when zero base fee market is configured
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">doc-change-required</span>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description

This PR allows to replace txs on zero base fee markets, or on gas price network, where the txs have gas price set to zero (with `min-gas-price=0`).

To achieve that we force the `tx-pool-price-bump=0` when the `zeroBaseFee:true` genesis option is present.
But this was not enough, since the transaction replacement rules were forcing the new price to be strictly greater than the price bump, that in my opinion is not intuitive, since for example if your existing tx has a gas price of 100, and the price bump is 10%, then we should accept a valid replacement a tx with a gas price of 110, and not 111 as it was before.
So the other change is to accept, as valid replacement, tx with a gas price greater than or equal to the price bump. This make also the `tx-pool-price-bump=0` case more intuitive, since you can replace a tx without increasing the gas price.

`doc-change-required` to explain that if `zeroBaseFee:true` in the genesis, then `tx-pool-price-bump=0` is forced internally, and any attempt to specify a value for it results in an error

## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->

fixes #6043
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-24 19:11:42 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6078" class=".btn">#6078</a>
</td>
<td>
<b>
ETC 'Spiral' network upgrade
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
## PR description
This PR adds support to [ECIP-1109](https://ecips.ethereumclassic.org/ECIPs/ecip-1109).
Block number is set to https://github.com/ethereumclassic/ECIPs/pull/514, already set in core-geth in https://github.com/etclabscore/core-geth/pull/571
I also set the DNS discovery tree to what's in [core-geth#bootnodes_mordor.go](https://github.com/etclabscore/core-geth/blob/v1.12.14/params/bootnodes_mordor.go#L29)
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-24 18:48:52 +0000 UTC
</div>
</div>

50 changes: 0 additions & 50 deletions pull-requests/hyperledger/cacti.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -193,53 +193,3 @@ For rebasing and squashing, here's a [must read guide](https://github.com/servo/
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/cacti/pull/2830" class=".btn">#2830</a>
</td>
<td>
<b>
build(deps): bulk fix CVEs via dependency resolution overrides 2023-10-23
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">dependent</span>
</td>
<td>
1. Couldn't get rid of vulnerable versions in a couple of dependencies
because the underlying dependencies have gone ESM only which is a blocker
for us at the moment unfortunately.
2. Swapped out the ubiquity TS client to a version of it that I self
published onto npm after a full renovation of all of its dependencies.

Depends on #2807 (because that one also has a couple of dependency bumps
that are needed to eliminate the vulnerabilities)

Fixes #2828
Fixes #2544

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

**Pull Request Requirements**
- [x] Rebased onto `upstream/main` branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
- [x] Have git sign off at the end of commit message to avoid being marked red. You can add `-s` flag when using `git commit` command. You may refer to this [link](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) for more information.
- [x] Follow the Commit Linting specification. You may refer to this [link](https://www.conventionalcommits.org/en/v1.0.0-beta.4/#specification) for more information.

**Character Limit**
- [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

**A Must Read for Beginners**
For rebasing and squashing, here's a [must read guide](https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing) for beginners.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-24 21:11:13 +0000 UTC
</div>
</div>

70 changes: 0 additions & 70 deletions pull-requests/hyperledger/fabric.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -739,73 +739,3 @@ N/A
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/fabric/pull/4489" class=".btn">#4489</a>
</td>
<td>
<b>
Update docs on checkcommitreadiness with inspect flag
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<!--- DELETE MARKDOWN COMMENTS BEFORE SUBMITTING PULL REQUEST. -->

<!--- Provide a descriptive summary of your changes in the Title above. -->

#### Type of change

<!--- What type of change? Pick one option and delete the others. -->

- Documentation update

#### Description

This patch updates documents on `checkcommitreadiness` with `inspect` flag.

#### Additional details

<!--- Additional implementation details or comments to reviewers. -->
<!--- Summarize how the pull request was tested (if not obvious from commit). -->

#### Related issues

<!--- Include a link to any associated issues, e.g. Jira issue or approved rfc. -->
Resolve #4428

<!---
#### Release Note
If change impacts current users, uncomment Release Note heading and provide
release note text.
Also, copy release note text into the release specific /release_notes file.
-->

<!--
Checklist (DELETE AFTER READING):
- `Signed-off-by` added to commits (required for DCO check to pass)
- Tests have been added/updated (required for bug fixes and features)
- Unit and/or integration tests pass locally
- Run linters and checks locally using 'make checks'
- If change requires documentation updates, make updates in pull request,
or open a separate issue and provide link
- Squash commits into a single commit, unless a stack of commits is
intentional to assist reviewers or to preserve review comments.
- For additional contribution guidelines see the project's CONTRIBUTING.md file
-->

</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-24 23:58:50 +0000 UTC
</div>
</div>

0 comments on commit 2c2b6f6

Please sign in to comment.