Skip to content

Commit

Permalink
Update PRs (#5434)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hyperledger-bot
hyperledger-bot authored Nov 14, 2023
1 parent 74e45bd commit 6f94894
Show file tree
Hide file tree
Showing 7 changed files with 136 additions and 134 deletions.
26 changes: 0 additions & 26 deletions pull-requests/hyperledger-labs/fabric-operator.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,3 @@ permalink: /pull-requests/hyperledger-labs/fabric-operator
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/fabric-operator/pull/152" class=".btn">#152</a>
</td>
<td>
<b>
Make use tags default to true for couchdb
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
https://github.com/hyperledger-labs/fabric-operator/issues/148
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-07 07:24:38 +0000 UTC
</div>
</div>

54 changes: 54 additions & 0 deletions pull-requests/hyperledger-labs/open-enterprise-agent.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,60 @@ permalink: /pull-requests/hyperledger-labs/open-enterprise-agent
# open-enterprise-agent <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger-labs/open-enterprise-agent){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/open-enterprise-agent/pull/786" class=".btn">#786</a>
</td>
<td>
<b>
test: add wallet uma permission management tests
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">prism-agent</span>
</td>
<td>
# Overview
<!-- What this PR does, and why is needed, a useful description is expected, and relevant tickets should be mentioned -->

Fixes ATL-6082. Add unit tests for self-service wallet management.

## Checklist

### My PR contains...
* [x] No code changes (changes to documentation, CI, metadata, etc.)
* [ ] Bug fixes (non-breaking change which fixes an issue)
* [ ] Improvements (misc. changes to existing features)
* [ ] Features (non-breaking change which adds functionality)

### My changes...
* [ ] are breaking changes
* [x] are not breaking changes
* [ ] If yes to above: I have updated the documentation accordingly

### Documentation
* [x] My changes do not require a change to the project documentation
* [ ] My changes require a change to the project documentation
* [ ] If yes to above: I have updated the documentation accordingly

### Tests
* [ ] My changes can not or do not need to be tested
* [ ] My changes can and should be tested by unit and/or integration tests
* [ ] If yes to above: I have added tests to cover my changes
* [ ] If yes to above: I have taken care to cover edge cases in my tests

</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-14 10:24:24 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand Down
42 changes: 0 additions & 42 deletions pull-requests/hyperledger/besu.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -577,45 +577,3 @@ Fixes #6140
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6138" class=".btn">#6138</a>
</td>
<td>
<b>
Backward sync invalid block causes Out of Memory error
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description
Besu fails to import a block due to an invalid block error during BWS and then fails with an OutOfMemoryError.

The fix is to limit the included blocks and block headers in the `onBadChain` event. I have set the limit to be the same as what is set for the maximum number of entries cached in the `BadBlockManager`. The `BadBlockManager` is currently the only listener for this event and the limit of 100 also seems reasonable for the `onBadChain` event.

### Heap dump analysis
![image (1)](https://github.com/hyperledger/besu/assets/909467/bcb2e0b7-bc43-460c-a5be-a3134f018ca9)

![image (2)](https://github.com/hyperledger/besu/assets/909467/5fd48a0f-c075-476a-b2b7-e753a9debbc3)

## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
fixes #6118
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-07 06:34:08 +0000 UTC
</div>
</div>

60 changes: 0 additions & 60 deletions pull-requests/hyperledger/bevel.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,63 +226,3 @@ fixes #2399
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/bevel/pull/2419" class=".btn">#2419</a>
</td>
<td>
<b>
New Document Restructure
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
Base theme changed along with light/dark toggle
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-07 11:21:02 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/bevel/pull/2418" class=".btn">#2418</a>
</td>
<td>
<b>
feat(shared): Implement GitHub Spellcheck and grammar linting for Pull request.
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
This pull request implements the GitHub Spellcheck feature to automatically check the spelling and grammar in commit messages for all Pull Requests (PRs).

Changes Made:
- Added GitHub Spellcheck and grammar linting integration to the repository
- Configured the spellcheck tool to check commit messages in PRs
- Configured the language tool for grammar linting.

Fixes: #2327
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-07 08:59:30 +0000 UTC
</div>
</div>

2 changes: 1 addition & 1 deletion pull-requests/hyperledger/iroha.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permalink: /pull-requests/hyperledger/iroha
</td>
<td>
<b>
Ci/docker image validator
[ci]: docker image validator
</b>
</td>
</tr>
Expand Down
76 changes: 76 additions & 0 deletions pull-requests/hyperledger/solang.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,82 @@ permalink: /pull-requests/hyperledger/solang
# solang <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger/solang){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/solang/pull/1595" class=".btn">#1595</a>
</td>
<td>
<b>
Add a feature flag for the language server
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
The language server alone pulls over 200 dependencies, or close to half of our total dependencies. Currently, `cargo build` causes to compile 552 crates. With this feature flag, a `cargo build --no-default-features --features llvm,wasm_opt` compiles only 296 crates.

And there are some chunky ones in the language server too. With the LS I get the following timings:

|Rank| Unit | Total | Codegen | Features
|-- | -- | -- | -- | --
|1. | wasm-opt-sys v0.112.0 build script (run) | 50.1s |   |  
|2. | **ethers-solc v2.0.10** | 16.0s | 7.1s (45%) | async, futures-util, sha2, svm, svm-builds, svm-solc
|3. | solang v0.3.3 bin "solang" | 15.8s |   | contract-build, default, ethers-core, forge-fmt, inkwell, language_server, libc, llvm, rust-lapper, tokio, tower-lsp, wasm-opt, wasm_opt
|4. | solang-parser v0.3.3 build script (run) | 13.8s |   | default
|5. | solang-parser v0.3.2 build script (run) | 13.4s |   | default
|6. | **lsp-types v0.94.1** | 9.9s | 1.1s (11%) | default
|7. | **ethers-core v2.0.10** | 8.1s | 3.5s (43%) |  
|8. | lalrpop v0.20.0 | 7.9s | 3.1s (39%) |  
|9. | **tokio v1.34.0** | 7.1s | 3.6s (51%) | bytes, default, fs, io-std, io-util, libc, macros, mio, net, num_cpus, process, rt, rt-multi-thread, signal-hook-registry, socket2, sync, time, tokio-macros
|10. | solang v0.3.3 | 6.5s | 2.4s (38%) | contract-build, default, ethers-core, forge-fmt, inkwell, language_server, libc, llvm, rust-lapper, tokio, tower-lsp, wasm-opt, wasm_opt
|11. | syn v1.0.109 | 6.2s | 2.6s (41%) | clone-impls, default, derive, extra-traits, fold, full, parsing, printing, proc-macro, quote, visit, visit-mut
|12. | **foundry-config v0.2.0** | 6.2s | 4.1s (66%) |


Main offender is still `wasm-opt` by far, but we already have a flag for this.




</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-14 10:25:37 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/solang/pull/1594" class=".btn">#1594</a>
</td>
<td>
<b>
Fix broken build
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
For some reason, cargo is not pick the latest version of ethers-core. This breaks the build. Add a line to Cargo.toml fixes the problem.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-14 09:27:50 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand Down
10 changes: 5 additions & 5 deletions trending/recent-prs.md
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@

[2889](https://github.com/hyperledger/cacti/pull/2889) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-plugin-persistence-fabric
[1595](https://github.com/hyperledger/solang/pull/1595) Add a feature flag for the language server

[2887](https://github.com/hyperledger/cacti/pull/2887) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-plugin-ledger-connector-quorum
[786](https://github.com/hyperledger-labs/open-enterprise-agent/pull/786) test: add wallet uma permission management tests

[2886](https://github.com/hyperledger/cacti/pull/2886) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-plugin-odap-hermes
[1594](https://github.com/hyperledger/solang/pull/1594) Fix broken build

[2885](https://github.com/hyperledger/cacti/pull/2885) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-plugin-ledger-connector-iroha
[2889](https://github.com/hyperledger/cacti/pull/2889) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-plugin-persistence-fabric

[2884](https://github.com/hyperledger/cacti/pull/2884) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-test-plugin-htlc-eth-besu
[2888](https://github.com/hyperledger/cacti/pull/2888) build(deps): bump axios from 1.5.1 to 1.6.0 in /packages/cactus-test-plugin-htlc-eth-besu-erc20


[See more >>>](https://start-here.hyperledger.org/pull-requests)

0 comments on commit 6f94894

Please sign in to comment.