Skip to content

Commit

Permalink
Update PRs (#5502)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hyperledger-bot
hyperledger-bot authored Nov 27, 2023
1 parent 798cc1d commit a069c67
Show file tree
Hide file tree
Showing 9 changed files with 29 additions and 345 deletions.
54 changes: 0 additions & 54 deletions pull-requests/hyperledger-labs/open-enterprise-agent.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -338,57 +338,3 @@ Fixes https://input-output.atlassian.net/browse/ATL-6019
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/open-enterprise-agent/pull/793" class=".btn">#793</a>
</td>
<td>
<b>
docs: add multitenancy keycloak integration tutorials
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">docs</span>
</td>
<td>
# Overview
<!-- What this PR does, and why is needed, a useful description is expected, and relevant tickets should be mentioned -->

Fixes ATL-xxxx

## Checklist

### My PR contains...
* [x] No code changes (changes to documentation, CI, metadata, etc.)
* [ ] Bug fixes (non-breaking change which fixes an issue)
* [ ] Improvements (misc. changes to existing features)
* [ ] Features (non-breaking change which adds functionality)

### My changes...
* [ ] are breaking changes
* [x] are not breaking changes
* [ ] If yes to above: I have updated the documentation accordingly

### Documentation
* [ ] My changes do not require a change to the project documentation
* [x] My changes require a change to the project documentation
* [x] If yes to above: I have updated the documentation accordingly

### Tests
* [x] My changes can not or do not need to be tested
* [ ] My changes can and should be tested by unit and/or integration tests
* [ ] If yes to above: I have added tests to cover my changes
* [ ] If yes to above: I have taken care to cover edge cases in my tests

</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-20 09:21:52 +0000 UTC
</div>
</div>

28 changes: 0 additions & 28 deletions pull-requests/hyperledger-labs/yui-relayer.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,31 +42,3 @@ This allows the client-id, connection-id, and channel-id in path.json to be set
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/yui-relayer/pull/124" class=".btn">#124</a>
</td>
<td>
<b>
change interfaces related to MsgCreateClient
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
- replace `LightClient::CreateMsgCreateClient` with `CreateInitialLightClientState`
- remove `FinalityAware::GetFinalizedHeader`
- restore `FinalityAware::GetLatestFinalizedHeader`
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-20 07:43:34 +0000 UTC
</div>
</div>

26 changes: 26 additions & 0 deletions pull-requests/hyperledger/aries-framework-javascript.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,32 @@ permalink: /pull-requests/hyperledger/aries-framework-javascript
# aries-framework-javascript <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger/aries-framework-javascript){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/aries-framework-javascript/pull/1650" class=".btn">#1650</a>
</td>
<td>
<b>
refactor: move message-pickup directory
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
For some strange reason, the 'i' in `message-pickup` module directory is an special character, which makes it difficult to create patches to properly test updates in that module (like the ones in #1638), so this small PR is just fixing it using a regular 'i'.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-27 12:23:20 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand Down
32 changes: 0 additions & 32 deletions pull-requests/hyperledger/aries-framework-kotlin.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,35 +40,3 @@ Tested against `aca-py`
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/aries-framework-kotlin/pull/14" class=".btn">#14</a>
</td>
<td>
<b>
Fix crash during pickup if network is turned off
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
In the current implementation, if the network is turned off, pickup of messages causes an application crash.

This PR fixes this by silently ignoring crashes during a pickup (as pickup will be retried at the polling frequency specified).

Also, there was no exception handling during the establishment of a connection (in the `WalletMainActivity`), this has been fixed too.

@conanoc / @DrumRobot request you to review this and merge.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-20 07:47:42 +0000 UTC
</div>
</div>

2 changes: 1 addition & 1 deletion pull-requests/hyperledger/aries-vcx.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ permalink: /pull-requests/hyperledger/aries-vcx
</tr>
<tr>
<td>
<span class="chip">review:level-2</span>
</td>
<td>
- Derives `Display` trait for all aries messages
Expand Down
149 changes: 0 additions & 149 deletions pull-requests/hyperledger/besu.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1863,152 +1863,3 @@ Plus a couple of log fixes.
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6189" class=".btn">#6189</a>
</td>
<td>
<b>
Update OpenJDK latest Docker image to use Java 21
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description

Switched base image to `ubuntu:rolling`, that follow any stable Ubuntu release, currently 23.10) since OpenJDK Java 21 is not available on latest LTS Ubuntu.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-20 11:43:34 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6188" class=".btn">#6188</a>
</td>
<td>
<b>
Add experimental x-trie-log subcommand for one-off backlog prune
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">TeamGroot</span>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description

Part of https://github.com/hyperledger/besu/issues/5390

## TODO

- [x] Test on a throwaway mainnet node: https://github.com/hyperledger/besu/pull/6188#issuecomment-1820156907
- took **8m 48s** to prune 293458 trie logs (18 GB) on ~5 week old node
- [ ] Test on one of our oldest nodes to understand duration - my guess is it will be in the order of minutes, hopefully less than 1 hour.
- [ ] If it's really slow, could optimise by loading all trie logs once and reuse for count as well as prune (or just prune instead of count).

## To install on a node

```
cd /opt/besu
sudo wget -O 6188.tar.gz https://output.circle-artifacts.com/output/job/a7a06df9-cf33-4115-89d1-413c86facd71/artifacts/0/distributions/besu-23.10.3-SNAPSHOT.tar.gz
sudo tar zxf 6188.tar.gz --transform s/besu-23.10.3-SNAPSHOT/6188/
time sudo /opt/besu/6188/bin/besu --config-file=/etc/besu/config.toml storage x-trie-log count
```

## Usage and examples

```
$BESU storage x-trie-log -h
Usage: besu storage x-trie-log [-hV] [COMMAND]
Manipulate trie logs
-h, --help Show this help message and exit.
-V, --version Print version information and exit.
Commands:
count This command counts all the trie logs
prune This command prunes all trie log layers below the retention threshold,
including orphaned trie logs.
```

```
$BESU --genesis-file=genesis.json --data-path=besu --data-storage-format=BONSAI storage x-trie-log count
...
Counting trie logs...
trieLog count: 512
- canonical count: 512
- fork count: 0
- orphaned count: 0
```

```
$BESU --genesis-file=genesis.json --data-path=besu --data-storage-format=BONSAI storage x-trie-log prune
```

```
$BESU --genesis-file=genesis.json --data-path=besu --data-storage-format=BONSAI --Xbonsai-trie-log-retention-threshold=512 --Xbonsai-trie-log-pruning-limit=513 storage x-trie-log prune
...
Counting trie logs before prune...
trieLog count: 615
- canonical count: 512
- fork count: 0
- orphaned count: 103
Total to prune = 615 (total) - 512 (retention threshold) =
=> 103
Estimated number of batches = max(103 (total to prune) / 513 (batch size), 1) = 1
Pruning batch 1
-----------------
2023-11-20 19:45:19.639+10:00 | main | INFO | TrieLogPruner | Loading first 513 trie logs from database...
2023-11-20 19:45:19.649+10:00 | main | DEBUG | TrieLogPruner | Pruned 91 orphaned trie logs from database...
2023-11-20 19:45:19.649+10:00 | main | INFO | TrieLogPruner | Loaded 422 trie logs from database
2023-11-20 19:45:19.657+10:00 | main | DEBUG | TrieLogPruner | pruned 0 trie logs from 0 blocks
Number pruned in batch = 91
Running total number pruned =
=> 91 of 103
Pruning batch 2
-----------------
2023-11-20 19:45:19.657+10:00 | main | INFO | TrieLogPruner | Loading first 513 trie logs from database...
2023-11-20 19:45:19.665+10:00 | main | DEBUG | TrieLogPruner | Pruned 12 orphaned trie logs from database...
2023-11-20 19:45:19.665+10:00 | main | INFO | TrieLogPruner | Loaded 501 trie logs from database
2023-11-20 19:45:19.666+10:00 | main | DEBUG | TrieLogPruner | pruned 0 trie logs from 0 blocks
Number pruned in batch = 12
Running total number pruned =
=> 103 of 103
Trie log prune complete!
Counting trie logs after prune...
trieLog count: 512
- canonical count: 512
- fork count: 0
- orphaned count: 0
```
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-20 10:22:37 +0000 UTC
</div>
</div>

46 changes: 0 additions & 46 deletions pull-requests/hyperledger/cacti.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -294,49 +294,3 @@ For rebasing and squashing, here's a [must read guide](https://github.com/servo/
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/cacti/pull/2899" class=".btn">#2899</a>
</td>
<td>
<b>
tools(cmd-api-server): address CVE: CVE-2022-25881
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
### Commit to be reviewed

tools(cmd-api-server): address CVE: CVE-2022-25881

`Primary Changes:
Updated the https-cache-semantics to latest version inside the cmd-api-server package`

Fixes: #2862


**Pull Request Requirements**
- [x] Rebased onto `upstream/main` branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
- [x] Have git sign off at the end of commit message to avoid being marked red. You can add `-s` flag when using `git commit` command. You may refer to this [link](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) for more information.
- [x] Follow the Commit Linting specification. You may refer to this [link](https://www.conventionalcommits.org/en/v1.0.0-beta.4/#specification) for more information.

**Character Limit**
- [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
- [x] Commit Message per line must not exceed 80 characters (including spaces and special characters).

**A Must Read for Beginners**
For rebasing and squashing, here's a [must read guide](https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing) for beginners.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-11-20 06:55:59 +0000 UTC
</div>
</div>

Loading

0 comments on commit a069c67

Please sign in to comment.