Skip to content

Commit

Permalink
Update PRs (#5338)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hyperledger-bot
hyperledger-bot authored Oct 25, 2023
1 parent 958a001 commit a1dcb65
Show file tree
Hide file tree
Showing 8 changed files with 1,212 additions and 44 deletions.
13 changes: 9 additions & 4 deletions pull-requests/hyperledger-labs/harmonia.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ permalink: /pull-requests/hyperledger-labs/harmonia
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/harmonia/pull/59" class=".btn">#59</a>
PR <a href="https://github.com/hyperledger-labs/harmonia/pull/61" class=".btn">#61</a>
</td>
<td>
<b>
Added claim by proof path to committed EVM asset
Added EVM signatures as notarisation proof
</b>
</td>
</tr>
Expand All @@ -27,14 +27,19 @@ permalink: /pull-requests/hyperledger-labs/harmonia
</td>
<td>
After committing an EVM asset, the counterparty signs the draft transaction which locks the asset until the committed asset is claimed or reverted.
Updated EVM contract to allow EVM commit recipient to claim providing proofs of notarisation.
Updated java contract wrappers
Added new flows and updated existing flows to handle EVM signatures as proof of notarization
Added tests to claim EVM asset using proof of notarisation

After committing an EVM asset, the counterparty signs the draft transaction which locks the asset until the committed asset is claimed or reverted.
While both parties can revert the EVM asset, claiming without proofs of notarisation is only possible by the committer/owner of the EVM asset. The recipient must present proofs that the draft transaction was notarised in order to claim the EVM asset.
This PR adds the possibility to collect EVM signatures from Corda parties that verify and attest that a certain signature over the draft transaction hash belongs to a certain public key. These signatures can be used by the EVM asset recipient to claim the EVM asset independently from the EVM asset owner.
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-24 16:08:08 +0000 UTC
Created At 2023-10-25 12:22:28 +0000 UTC
</div>
</div>

54 changes: 54 additions & 0 deletions pull-requests/hyperledger-labs/open-enterprise-agent.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,60 @@ permalink: /pull-requests/hyperledger-labs/open-enterprise-agent
# open-enterprise-agent <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger-labs/open-enterprise-agent){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger-labs/open-enterprise-agent/pull/767" class=".btn">#767</a>
</td>
<td>
<b>
test: add anoncreds issuance happy path bdd scenario
</b>
</td>
</tr>
<tr>
<td>
<span class="chip">docs</span><span class="chip">infra</span>
</td>
<td>
# Overview
<!-- What this PR does, and why is needed, a useful description is expected, and relevant tickets should be mentioned -->

Adds an integration test for anoncreds issuance

## Checklist

### My PR contains...
* [x] No code changes (changes to documentation, CI, metadata, etc.)
* [ ] Bug fixes (non-breaking change which fixes an issue)
* [ ] Improvements (misc. changes to existing features)
* [ ] Features (non-breaking change which adds functionality)

### My changes...
* [ ] are breaking changes
* [x] are not breaking changes
* [ ] If yes to above: I have updated the documentation accordingly

### Documentation
* [x] My changes do not require a change to the project documentation
* [ ] My changes require a change to the project documentation
* [ ] If yes to above: I have updated the documentation accordingly

### Tests
* [ ] My changes can not or do not need to be tested
* [x] My changes can and should be tested by unit and/or integration tests
* [ ] If yes to above: I have added tests to cover my changes
* [ ] If yes to above: I have taken care to cover edge cases in my tests

</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-25 10:28:15 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand Down
152 changes: 149 additions & 3 deletions pull-requests/hyperledger/besu.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,106 @@ permalink: /pull-requests/hyperledger/besu
# besu <span class="fs-3 right-align">[GitHub](https://github.com/hyperledger/besu){: .btn .mr-4 }</span>


<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6085" class=".btn">#6085</a>
</td>
<td>
<b>
create trielog state for tracing
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description

## Fixed Issue(s)

fixes #6050
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-25 08:53:36 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6083" class=".btn">#6083</a>
</td>
<td>
<b>
Add transaction selector based on min priority fee parameter
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
## PR description
Add transaction selector based on min priority fee parameter

## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-25 07:35:42 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
<td>
PR <a href="https://github.com/hyperledger/besu/pull/6082" class=".btn">#6082</a>
</td>
<td>
<b>
Add option to clique to skip creating empty blocks
</b>
</td>
</tr>
<tr>
<td>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description
Add an option to clique to skip creating empty blocks

## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
</td>
</tr>
</table>
<div class="right-align">
Created At 2023-10-25 06:50:57 +0000 UTC
</div>
</div>

<div>
<table>
<tr>
Expand Down Expand Up @@ -51,7 +151,7 @@ Bump 23.10.1-RC to 23.10.1 on release branch
</tr>
<tr>
<td>
<span class="chip">doc-change-required</span>
</td>
<td>
## PR description
Expand All @@ -64,6 +164,42 @@ Adds two new JsonRPC methods:

This PR does not add the transactionSelector based on `minPriorityFeePerGas`. It will be added in a different PR

Examples:

Example:
Request
`{"jsonrpc":"2.0","id":1,"method":"miner_setMinPriorityFee","params":[1]}`
Response:
```
{
"jsonrpc": "2.0",
"id": 1,
"result": true
}
```
Invalid request:
` {"jsonrpc":"2.0","id":1,"method":"miner_setMinPriorityFee","params":[-1]}
`Response:
```
{
"jsonrpc": "2.0",
"id": 1,
"result": false
}
```
Get method:
` {"jsonrpc":"2.0","id":1,"method":"miner_getMinPriorityFee","params":[]}
`Response:
```
{
"jsonrpc": "2.0",
"id": 1,
"result": 7
}
```




</td>
</tr>
Expand All @@ -87,17 +223,27 @@ This PR does not add the transactionSelector based on `minPriorityFeePerGas`. It
</tr>
<tr>
<td>
<span class="chip">doc-change-required</span>
</td>
<td>
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md -->

## PR description

This PR allows to replace txs on zero base fee markets, or on gas price network, where the txs have gas price set to zero (with `min-gas-price=0`).

To achieve that we force the `tx-pool-price-bump=0` when the `zeroBaseFee:true` genesis option is present.
But this was not enough, since the transaction replacement rules were forcing the new price to be strictly greater than the price bump, that in my opinion is not intuitive, since for example if your existing tx has a gas price of 100, and the price bump is 10%, then we should accept a valid replacement a tx with a gas price of 110, and not 111 as it was before.
So the other change is to accept, as valid replacement, tx with a gas price greater than or equal to the price bump. This make also the `tx-pool-price-bump=0` case more intuitive, since you can replace a tx without increasing the gas price.

`doc-change-required` to explain that if `zeroBaseFee:true` in the genesis, then `tx-pool-price-bump=0` is forced internally, and any attempt to specify a value for it results in an error

## Fixed Issue(s)
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
<!-- Example: "fixes #2" -->

fixes #6043
</td>
</tr>
</table>
Expand Down
Loading

0 comments on commit a1dcb65

Please sign in to comment.