Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spanId to the parsing error log #297

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added spanId to the parsing error log #297

wants to merge 8 commits into from

Conversation

anujgoyal1
Copy link
Contributor

Changed the error log to include spanId

@anujgoyal1 anujgoyal1 requested a review from a team December 30, 2021 11:50
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #297 (c04c899) into main (7ee3a8e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #297   +/-   ##
=========================================
  Coverage     79.58%   79.59%           
  Complexity     1286     1286           
=========================================
  Files           116      116           
  Lines          5128     5130    +2     
  Branches        465      465           
=========================================
+ Hits           4081     4083    +2     
  Misses          836      836           
  Partials        211      211           
Flag Coverage Δ
unit 79.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/enrichment/enrichers/HttpAttributeEnricher.java 93.61% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee3a8e...c04c899. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

avinashkolluru
avinashkolluru previously approved these changes Dec 30, 2021
@github-actions
Copy link

Unit Test Results

  75 files  ±0    75 suites  ±0   54s ⏱️ -16s
394 tests ±0  394 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c04c899. ± Comparison against base commit 7ee3a8e.

@anujgoyal1
Copy link
Contributor Author

anujgoyal1 commented Dec 30, 2021

Can't fix all the snyk checks because as of today Avro doesn't have a version with fix for vulnerability https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-2326698

Issues with no direct upgrade or patch:
  ✗ Denial of Service (DoS) [Medium Severity][https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-2326698] in com.fasterxml.jackson.core:jackson-databind@2.12.2
    introduced by org.apache.avro:avro@1.10.2 > com.fasterxml.jackson.core:jackson-databind@2.12.2
  This issue was fixed in versions: 2.13.1, 2.12.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants