🐛 Fix spring boot smoke test taking a long time, set more sensible de…

…fault for OPA endpoint (#343) * ✨ set default OPA endpoint to localhost * ⚡ set timeoout on waitForTraces
hypertrace · Jul 23, 2021 · 306eaa4 · 306eaa4
1 parent 9319d3e
commit 306eaa4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...xtensions/src/main/java/org/hypertrace/agent/otel/extensions/config/HypertraceConfig.java b/...xtensions/src/main/java/org/hypertrace/agent/otel/extensions/config/HypertraceConfig.java
@@ -54,7 +54,7 @@ private HypertraceConfig() {}
 
   static final String DEFAULT_SERVICE_NAME = "unknown";
   static final String DEFAULT_REPORTING_ENDPOINT = "http://localhost:4317";
-  static final String DEFAULT_OPA_ENDPOINT = "http://opa.traceableai:8181/";
+  static final String DEFAULT_OPA_ENDPOINT = "http://localhost:8181/";
   static final int DEFAULT_OPA_POLL_PERIOD_SECONDS = 30;
   // 128 KiB
   static final int DEFAULT_BODY_MAX_SIZE_BYTES = 128 * 1024;

diff --git a/smoke-tests/src/test/java/org/hypertrace/agent/smoketest/AbstractSmokeTest.java b/smoke-tests/src/test/java/org/hypertrace/agent/smoketest/AbstractSmokeTest.java
@@ -22,6 +22,7 @@
 import io.opentelemetry.proto.trace.v1.InstrumentationLibrarySpans;
 import io.opentelemetry.proto.trace.v1.Span;
 import java.io.IOException;
+import java.time.Duration;
 import java.util.Collection;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicLong;
@@ -162,6 +163,7 @@ protected static Stream<InstrumentationLibrarySpans> getInstrumentationLibSpanSt
 
   protected Collection<ExportTraceServiceRequest> waitForTraces(final int count) {
     return Awaitility.await()
+        .atMost(Duration.ofSeconds(10))
         .until(
             this::waitForTraces,
             exportTraceServiceRequests -> exportTraceServiceRequests.size() == count);