Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix/module.nix: expand nixos module for configuring hyprland #9006

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

bloxx12
Copy link
Contributor

@bloxx12 bloxx12 commented Jan 9, 2025

Describe your PR, what does it fix/add?

Expand the nixos module to be able to configure hyprland, just like the current home-manager module does. I think this would be neat, would probably not be upstreamed into nixpkgs though.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

@fufexan and I already talked a bit about this, I got around to making a PR only now though.

Is it ready for merging, or does it need work?

It works on my machine™, feel free to test.

@github-actions github-actions bot added the Nix NixOS issue label Jan 9, 2025
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance it looks alright, but I'll need to test it before approving.

nix/module.nix Outdated Show resolved Hide resolved
nix/module.nix Outdated Show resolved Hide resolved
Expand the nixos module to be able to configure hyprland, just like the
current home-manager module does.
@bloxx12 bloxx12 marked this pull request as ready for review January 11, 2025 11:00
@fufexan
Copy link
Member

fufexan commented Jan 12, 2025

This might be a skill issue on my end, but setting plugins causes this error. I'll keep investigating.
stacktrace.txt

@fufexan
Copy link
Member

fufexan commented Jan 18, 2025

I've finally had time to debug this. Turns out the package definition in the top-most let...in was shadowing with lib.types; ... package. I've moved the whole thing down and added a lib.mkMerge for legibility.
Also removed adding xwayland as that's already handled.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently running the config generated by this module. All seems well.

LGTM

@fufexan fufexan merged commit f56153a into hyprwm:main Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nix NixOS issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants