-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated * to itwinui 3 #141
base: main
Are you sure you want to change the base?
Conversation
"@itwin/itwinui-icons-react": "^2.2.0", | ||
"@itwin/itwinui-react": "^2.12.18", | ||
"@itwin/itwinui-icons-react": "^2.9.0", | ||
"@itwin/itwinui-react": "^3.16.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think itiwnui would need to become a peer dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated all packages in monorepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be no individual pnpm-lock file per pkg
this is a monorepo where they share a single lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
? "#A47854" /** $iui-color-background-oak */ | ||
: "#4585A5" /** $iui-color-background-steelblue */ | ||
} | ||
<Tile.Wrapper key={iTwin?.id} {...(tileProps ?? {})}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will cause issue with anyone using the property overrides, as they used to be able to modifiy all the props through useIndidividualState, which infrastructure cloud use, and now we completely loose this ability, it is no longer possible to override anything in the tile, for example, if you want to add information to the bottom of the tile, or change the image to add a saved view drop down, that is no longer possible. I dont think this is a viable solution for this particular package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, if we really need thos, we need to take into account the tile props and redistribute them within this Tile.Wrapper elements as https://github.com/iTwin/iTwinUI/blob/5e310430f93094ff6aaa2bf1255d8a54cf5a103c/packages/itwinui-react/src/core/Tile/Tile.tsx#L544 is already doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, if we really need thos, we need to take into account the tile props and redistribute them within this Tile.Wrapper elements as iTwin/iTwinUI@
5e31043
/packages/itwinui-react/src/core/Tile/Tile.tsx#L544 is already doing.
I believe I did it in the same way, the remaining props are tileProps
which are spread in the Tile.Wrapper component
UPDATE
Note
would make some suggestions, pending state at merge, separate issues can be created