Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Auto Tag workflow for newer JQ version #194

Merged
merged 1 commit into from
Jan 24, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/auto_tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:

jobs:
preparation:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's never experience an issue because Github Action OS defaults change 😅

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to experience issues and be on the cutting edge, otherwise, we will be postponing upgrades all the time 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a stable deployment procedure, not cutting edge. But that's your domain, your call.

# This should allow parallel runs in a chain, e.g. OSS->Content->Experience->Commerce
# whilst allowing Satis to process
timeout-minutes: 30
Expand Down Expand Up @@ -153,12 +153,12 @@ jobs:
# if they exist, to update the values of the keys in the require object.
- name: Patch composer require versions
run: |
jq --argfile release release.json '
jq --slurpfile release <(cat release.json) '
.require |= (
to_entries |
map({
key: .key,
value: (if ($release[.key]) then $release[.key] else .value end)
value: (if ($release[0][.key]) then $release[0][.key] else .value end)
}) | from_entries
)
' composer.json > composer.tmp
Expand Down
Loading