zipl: Update inline assembly for GCC 15 #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly escape % (as %%) for extended assembly in stage3.c in start_kernel(). Fixes: ibm-s390-linux#179 Signed-off-by: Dan Horák <dan@danny.cz>
|
FWIW disassembly shows the expected instructions when built with both GCC 14 and GCC 15 (I mean when using the new code). I have also verified the old code produces the same instructions with GCC 14 as the new one from this MR. |
|
FTR, this has been backported as https://src.fedoraproject.org/rpms/s390utils/c/9886d22bc2f4af942f60627b6345779d6194d4ec?branch=rawhide in Fedora. |
stefan-haberland
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly escape % (as %%) for extended assembly in stage3.c in start_kernel().
Fixes: #179