Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❌ Fixed Clinical Errors Resolver #1177

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

demariadaniel
Copy link
Contributor

Link to Issue

Testing from review of: icgc-argo/rdpc-ui#173 (comment)

Description

  • Clinical Errors resolver is not working independently of Clinical Data resolver; issue can be reproduced in Dev

Screenshots showing fixed query working for both Clinical Errors and Clinical Data

Screenshot 2024-04-15 at 4 27 10 PM Screenshot 2024-04-15 at 4 26 55 PM

Checklist

Type of Change

  • Bug
  • Refactor
  • New Feature
  • Release Candidate

Checklist before requesting review:

  • Check branch (code change PRs go to develop not master)
  • Check copyrights for new files
  • Manual testing
  • Regression tests completed and passing (double check number of tests).
  • Spelling has been checked.
  • Updated swagger docs accordingly (check it's still valid)
  • Set validationDependency in meta tag for Argo Dictionary fields used in code

@demariadaniel demariadaniel merged commit 60342e6 into develop Apr 16, 2024
@demariadaniel demariadaniel deleted the bug/fix-clinical-error-resolver branch April 16, 2024 14:42
@demariadaniel demariadaniel mentioned this pull request Apr 17, 2024
11 tasks
UmmulkiramR pushed a commit that referenced this pull request Jun 21, 2024
* develop:
  fix to resolve incorrect merging of therapies into treatments (#1187)
  Chore / Move Clinical Service Types (#1185)
  ❌ Sort Invalid Clinical Records first (#1184)
  RC 1.87.1
  Remove unused argument (#1179)
  🏷️ 1141 Add Exception Manifest to Donor tsv (#1178)
  Fixed Resolver (#1177)
  Add Exceptions to Program TSV (#1175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants