Skip to content

Commit

Permalink
⬆️ #2299 - Upgrade dependencies (#2305)
Browse files Browse the repository at this point in the history
  • Loading branch information
samrichca authored Jun 14, 2022
1 parent c3416f4 commit ba9b4dd
Show file tree
Hide file tree
Showing 6 changed files with 17,639 additions and 28,273 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,5 @@ chromedriver.log

.graphqlconfig
.cache
uikit/dist

**/.DS_STORE
29 changes: 1 addition & 28 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ Navigate to `/compose` (`cd ./compose`) and Follow the instructions found in [`c

### Writing commits

To keep commit messages consistent, we use [gitmoji-cli](https://www.npmjs.com/package/gitmoji-cli), available as a dev dependency

- `npm run commit` will start interactive commit tool
- configuring gitmoji-cli: `npm run gitmoji-config`
To keep commit messages consistent, we use [gitmoji](https://gitmoji.dev). To easily access emojis on Mac, press ctrl+cmd+space.

### Type checking

Expand All @@ -50,27 +47,3 @@ To keep commit messages consistent, we use [gitmoji-cli](https://www.npmjs.com/p
[![Storybook](https://img.shields.io/badge/React-Storybook-ff69b4)](https://argo-ui-storybook.netlify.com)
[![npm version](https://badge.fury.io/js/%40icgc-argo%2Fuikit.svg)](https://badge.fury.io/js/%40icgc-argo%2Fuikit)
[![TypeScript](https://img.shields.io/badge/types-%20TypeScript-blue)](https://www.typescriptlang.org/)

`/uikit` contains the reusable UI components for Argo.

### Uikit Development

- Creating a new component: `npm run create-component`
- **Important:** If new dependencies are added for uikit, please include in `uikit/package.release.json`

### Build and publish to NPM

Increase `version` under `uikit/package.release.json`

#### Automated process (recommended)

1. Merge that change to `develop`, and let the Jenkins pipeline handle it

#### Manual process (discouraged, but available)

1. Run `npm run build-uikit` which performs the following:
2. Run `npm run publish-uikit` to publish latest version to npm

### Restriction

- `uikit` components should not reference (`import`) anything outside of the `uikit` directory
6 changes: 6 additions & 0 deletions global/hooks/useAuthContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ import urlJoin from 'url-join';
import refreshJwt from 'global/utils/refreshJwt';
import queryString from 'query-string';

declare global {
interface Navigator {
msSaveBlob?: (blob: any, defaultName?: string) => boolean;
}
}

type T_AuthContext = {
egoJwt?: string;
logOut: (path?: string) => void;
Expand Down
2 changes: 1 addition & 1 deletion global/utils/common.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const displayDateAndTime = (date: string | Date) => {
};

export const sleep = (time: number = 2000) =>
new Promise((resolve) => {
new Promise<void>((resolve) => {
setTimeout(() => {
resolve();
}, time);
Expand Down
Loading

0 comments on commit ba9b4dd

Please sign in to comment.