Skip to content

Commit

Permalink
Cleanup clinical entity data table (#173)
Browse files Browse the repository at this point in the history
* strict equality check

* re org files

* clean up scoping

* cleanup

* reorg to type narrow

* fix a bunch of TS errors

* readme update

* fix additional form data ts error

* fix TS generic error making type literal

* more type fixing

* fix types

* type fixes

* remove todo

* disable eslint for build

* remove todo

* add back ErrorNotification types instead of any type

* remove todo

* use correct programName instead of empty string

---------

Co-authored-by: Ciaran Schutte <ciaranschutte@oicr.on.ca>
  • Loading branch information
ciaranschutte and Ciaran Schutte authored Apr 15, 2024
1 parent f6e6d59 commit cead516
Show file tree
Hide file tree
Showing 22 changed files with 985 additions and 814 deletions.
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ You can start editing the page by modifying `app/page.tsx`. The page auto-update

This project uses [`next/font`](https://nextjs.org/docs/basic-features/font-optimization) to automatically optimize and load Inter, a custom Google Font.

```bash
npm run type-check
```

to see all type errors

## Env vars

Hosting environments that use runtime variables need to be able to send public client env vars to the client.
Expand Down Expand Up @@ -62,6 +68,7 @@ In an attempt to try and keep things clean and bug free, Emotion functions are u
react + react dom + emotion all versions needs to be in sync with @icgc-argo/uikit

## API Requests

We use both regular style HTTP endpoints and GQL endpoints.
We use Apollo GQL store on the frontend for most state.

Expand Down
11 changes: 7 additions & 4 deletions next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
/** @type {import('next').NextConfig} */

const nextConfig = {
reactStrictMode: true,
compiler: {
emotion: true,
},
reactStrictMode: true,
compiler: {
emotion: true,
},
eslint: {
ignoreDuringBuilds: true,
},
};

module.exports = nextConfig;
Loading

0 comments on commit cead516

Please sign in to comment.