Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Github action not failing when run_tests fails #399

Closed
10 tasks done
caleb-sitton-inl opened this issue Jan 15, 2025 · 1 comment
Closed
10 tasks done

[DEFECT] Github action not failing when run_tests fails #399

caleb-sitton-inl opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
defect Something isn't working priority-normal tasks that may be time sensitive, but are not necessarily critical

Comments

@caleb-sitton-inl
Copy link
Collaborator

caleb-sitton-inl commented Jan 15, 2025


Defect Description

Describe the defect

What did you expect to see happen?

When any test fails, the github action should show failure.

What did you see instead?

A test failed in the Test-Heron-Linux job, but the job was shown as successful on github. See https://github.com/idaholab/HERON/actions/runs/12756489666/job/35554720910

Do you have a suggested fix for the development team?

The github action appears to be reading the exit code from the last executed line in the check_py_coverage.sh shell script. This is the call to report_py_coverage.sh. Instead, the success of the github action should be based on the exit code from the run_tests call. Recording the run_tests exit code and explicitly exiting the check_py_coverage.sh shell script with the same code should fix the problem.

Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@caleb-sitton-inl caleb-sitton-inl added defect Something isn't working priority-normal tasks that may be time sensitive, but are not necessarily critical labels Jan 15, 2025
@caleb-sitton-inl caleb-sitton-inl self-assigned this Jan 15, 2025
@GabrielSoto-INL
Copy link
Collaborator

Issue closed with PR #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working priority-normal tasks that may be time sensitive, but are not necessarily critical
Projects
None yet
Development

No branches or pull requests

2 participants