[DEFECT] Github action not failing when run_tests fails #399
Labels
defect
Something isn't working
priority-normal
tasks that may be time sensitive, but are not necessarily critical
Defect Description
Describe the defect
What did you expect to see happen?
When any test fails, the github action should show failure.
What did you see instead?
A test failed in the Test-Heron-Linux job, but the job was shown as successful on github. See https://github.com/idaholab/HERON/actions/runs/12756489666/job/35554720910
Do you have a suggested fix for the development team?
The github action appears to be reading the exit code from the last executed line in the
check_py_coverage
.sh shell script. This is the call toreport_py_coverage.sh
. Instead, the success of the github action should be based on the exit code from therun_tests
call. Recording therun_tests
exit code and explicitly exiting thecheck_py_coverage.sh
shell script with the same code should fix the problem.Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.
Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.
Platform (please complete the following information):
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.
The text was updated successfully, but these errors were encountered: