Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage checking exit code fix #400

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

caleb-sitton-inl
Copy link
Collaborator

@caleb-sitton-inl caleb-sitton-inl commented Jan 15, 2025


Pull Request Description

What issue does this change request address?

#399

What are the significant changes in functionality due to this change request?

The check_py_coverage.sh script should now return the same exit code as run_tests. This should make the success of the Linux job in the github action correctly reflect the success of testing.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@caleb-sitton-inl caleb-sitton-inl added the Do Not Merge PR is not ready for merging label Jan 15, 2025
@GabrielSoto-INL GabrielSoto-INL self-requested a review January 16, 2025 16:08
@caleb-sitton-inl
Copy link
Collaborator Author

The failed Linux job when a test fails confirms that the action is now working properly.

@GabrielSoto-INL
Copy link
Collaborator

I can confirm that the failed ramp_freq Linux test results in a failed Test-HERON-Linux github action:
image

The particular job seems to exit correctly:
Error: Process completed with exit code 1.

Copy link
Collaborator

@GabrielSoto-INL GabrielSoto-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@caleb-sitton-inl caleb-sitton-inl removed the Do Not Merge PR is not ready for merging label Jan 16, 2025
@caleb-sitton-inl caleb-sitton-inl changed the title Debugging for github action failure when tests fail Coverage checking exit code fix Jan 16, 2025
@GabrielSoto-INL GabrielSoto-INL merged commit bb70736 into idaholab:devel Jan 16, 2025
4 checks passed
@caleb-sitton-inl caleb-sitton-inl deleted the debug-github-action branch January 17, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants