Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardinal submodule #79

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Conversation

cticenhour
Copy link
Member

This PR also removes the recursive updates for DAGMC in the documentation, as pyne is no longer being used (or tested against) by Cardinal.

@cticenhour cticenhour requested a review from simopier January 8, 2025 22:46
@cticenhour cticenhour self-assigned this Jan 8, 2025
@moosebuild
Copy link
Contributor

moosebuild commented Jan 8, 2025

Job Documentation, step Sync to remote on 728a4f7 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 8, 2025

Job Coverage, step Generate coverage on 728a4f7 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@cticenhour
Copy link
Member Author

Finally all green! Ready for review whenever you have time @simopier.

This page should be removed if/when Cardinal adds one of their own.
Copy link
Collaborator

@simopier simopier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!!

@simopier simopier merged commit 6407de2 into idaholab:devel Jan 18, 2025
9 checks passed
@cticenhour cticenhour deleted the update-cardinal branch January 18, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants