feat: adds option to remove old user assignment on account update #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-graesser
approved these changes
Jan 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour in AWS Control Tower Account Factory when updating an account with a new user email address does not drop the old user assignment, but rather just assigns the new user to the account. AWS support confirmed that this behaviour is by design and works as intended. An excerpt of the response we received was "This design allows for scenarios where you might want to maintain access for multiple users or ensure business continuity during transitions."
Since this behaviour might not always be desired, this PR adds the possibility to optionally drop the old user assignment after updating the provisioned product successfully. It uses the ssoadmin to achieve that.
The default behaviour is not affected and the new behaviour only works when
remove_account_assignment_on_updateis set totruealong with filling all the other attributes under thessoobject.A complete example can be found in the docs as a part of this PR.
Should solve #217