Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pid 2720 implement linked multi query validator #328

Conversation

AndriianChestnykh
Copy link
Collaborator

No description provided.

…into feature/PID-2720-Implement-LinkedMultiQuery-validator
…into feature/PID-2720-Implement-LinkedMultiQuery-validator
…into feature/PID-2720-Implement-LinkedMultiQuery-validator

# Conflicts:
#	contracts/test-helpers/RequestValidatorAuthV2Stub.sol
#	contracts/test-helpers/RequestValidatorV2Stub.sol
#	contracts/test-helpers/RequestValidatorV3Stub.sol
#	contracts/test-helpers/RequestValidatorV3_2Stub.sol
#	contracts/validators/AuthV2Validator.sol
#	contracts/validators/CredentialAtomicQueryV2ValidatorBase.sol
#	contracts/validators/CredentialAtomicQueryV3Validator.sol
#	contracts/validators/EthIdentityValidator.sol
@coveralls
Copy link

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12783388908

Details

  • 35 of 41 (85.37%) changed or added relevant lines in 3 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 82.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/lib/groth16-verifiers/Groth16VerifierLinkedMultiQuery10.sol 0 1 0.0%
contracts/validators/LinkedMultiQueryValidator.sol 34 39 87.18%
Files with Coverage Reduction New Missed Lines %
contracts/validators/EthIdentityValidator.sol 4 0.0%
contracts/verifiers/Verifier.sol 11 79.32%
Totals Coverage Status
Change from base Build 12772649743: 0.1%
Covered Lines: 1143
Relevant Lines: 1291

💛 - Coveralls

@daveroga daveroga merged commit 1e9c474 into PID-2709-full-multi-query-support-on-chain Jan 15, 2025
5 checks passed
@daveroga daveroga deleted the feature/PID-2720-Implement-LinkedMultiQuery-validator branch January 15, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants