Fix num2words call using non-standard lang code #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginhard
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Thanks for submitting the fix! I just added one commit to update the minimum version for num2words. Will merge when the CI passes, but will only be able to make a new release in 1-2 weeks, thanks for the patience!
Just to cross-link the issue in the original repo, also fixes coqui-ai#4098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
num2wordslibrary fixed their non-standard czech code so the fix to changecstoczis no longer needed and actually causes an exception.The fix was introduced to the
num2wordslibrary in this PR: savoirfairelinux/num2words#587Which was released in this version: https://github.com/savoirfairelinux/num2words/releases/tag/v0.5.14
Should resolve #236