Check for nullGenome on startup failure

igvteam · Sep 2, 2024 · 68d16cf · 68d16cf
1 parent bbc7989
commit 68d16cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/java/org/broad/igv/feature/genome/GenomeManager.java b/src/main/java/org/broad/igv/feature/genome/GenomeManager.java
@@ -234,15 +234,19 @@ public void setCurrentGenome(String genomePath, Genome newGenome) {
         if (IGV.hasInstance()) {
             IGV.getInstance().goToLocus(newGenome.getHomeChromosome()); //  newGenome.getDefaultPos());
             FrameManager.getDefaultFrame().setChromosomeName(newGenome.getHomeChromosome(), true);
-
             loadGenomeAnnotations(newGenome);
             IGV.getInstance().resetFrames();
             IGV.getInstance().getSession().clearHistory();
 
-            PreferencesManager.getPreferences().setLastGenome(newGenome.getId());
+            if(newGenome != Genome.nullGenome()) {
+                // This should only occur on startup failure
+                PreferencesManager.getPreferences().setLastGenome(newGenome.getId());
+            }
+
             if (PreferencesManager.getPreferences().getAsBoolean(Constants.CIRC_VIEW_ENABLED) && CircularViewUtilities.ping()) {
                 CircularViewUtilities.changeGenome(newGenome);
             }
+
             IGVEventBus.getInstance().post(new GenomeChangeEvent(newGenome));
         }
     }

diff --git a/src/main/java/org/broad/igv/feature/genome/load/JsonGenomeLoader.java b/src/main/java/org/broad/igv/feature/genome/load/JsonGenomeLoader.java
@@ -38,7 +38,7 @@ public JsonGenomeLoader(String genomePath) {
     public Genome loadGenome() throws IOException {
 
 
-        try (InputStream is = ParsingUtils.openInputStream(genomePath + "..")){
+        try (InputStream is = ParsingUtils.openInputStream(genomePath)){
 
             String jsonString = ParsingUtils.readContentsFromStream(is);