Lock file Optional when running logger #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigured via the deploy gui
…lt of deleting file
bshrewsbury
approved these changes
Aug 15, 2024
bshrewsbury
reviewed
Aug 15, 2024
| System.exit(0); | ||
| } | ||
| if (lockFile.exists()) | ||
| { |
There was a problem hiding this comment.
Would be helpful to put "Lockfile found at (the path to the lockfile), This is likely from an existing logger running. Maybe if you weren't so full of yourself you would have checked if the logger was already running. If the logger is not running, it is safe to remove the file and restart the logger.
bshrewsbury
reviewed
Aug 15, 2024
| { | ||
| perms.add(PosixFilePermission.OWNER_READ); | ||
| Files.setPosixFilePermissions(lockFile.toPath(), perms); |
There was a problem hiding this comment.
Whoa whoa whoa, logger is starting without Lock File, be careful to make sure you only run one logger at a time. When redeploying as a service you should stop the service before deployment. Use ps aux | grep java to confirm.
ds58
approved these changes
Aug 15, 2024
|
I'd prefer if we merge #12 instead. This removes the problem completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to make the lock file creation optional, it can be configured via the deploy gui, a checkbox has been added, by default it is true
Edge cases tested:
YoVariableLoggerDispatcherwithout any command line configurationYoVariableLoggerDispatcherwith the new command line argument