Added feature to shutdown the logger properly if the server crashes unexpectedly #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PotatoPeeler3000
force-pushed
the
feature/shutdown-properly
branch
from
56537fb to
9bbd628
Compare
ds58
requested changes
Sep 17, 2024
| @@ -563,13 +576,26 @@ public void receivedTimestampOnly(long timestamp) | |||
| { | |||
| synchronized (timestampUpdater) | |||
| { | |||
| // We haven't received any new timestamps, shutdown the logger gracefully | |||
| if (ticksWithoutNewTimestamp == TICKS_WITHOUT_DATA_BEFORE_SHUTDOWN) | |||
There was a problem hiding this comment.
can you make this if (!alreadyShutDown && ticksWithoutNewTimestamp >= TICKS_WITHOUT_DATA_BEFORE_SHUTDOWN)
There was a problem hiding this comment.
Ya good call
|
|
||
| if (alreadyShutDown) | ||
| { | ||
| LogTools.info("This may have already shutdown properly due to the server losing power for an extended amount of time"); |
There was a problem hiding this comment.
Not necessarily because of loss of power. I think you should just make this say This may have already shutdown properly because the connection to the YoVariableServer was lost
There was a problem hiding this comment.
Fair, went with: "This may have already shutdown because the connection to the server was lost"
ds58
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get a certain amount of ticks in a row without a new timestamp, then we shutdown.
This is because if power is lost to the server the JVM doesn't shutdown properly, therefore we can keep logging useless data, this prevents that.