Change how we send models to the Logger #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f concept, changed some print statements to make things more clear
src/main/java/us/ihmc/multicastLogDataProtocol/modelLoaders/DefaultLogModelProvider.java
Show resolved
Hide resolved
src/main/java/us/ihmc/robotDataLogger/YoVariableClientImplementation.java
Show resolved
Hide resolved
src/main/java/us/ihmc/robotDataLogger/logger/YoVariableLoggerDispatcher.java
Show resolved
Hide resolved
src/main/java/us/ihmc/robotDataLogger/logger/YoVariableLoggerListener.java
Outdated
Show resolved
Hide resolved
src/main/java/us/ihmc/multicastLogDataProtocol/modelLoaders/DefaultLogModelProvider.java
Outdated
Show resolved
Hide resolved
|
Tested on hardware, nothing blew up, looks good |
SylvainBertrand
requested changes
Feb 28, 2024
src/main/java/us/ihmc/multicastLogDataProtocol/modelLoaders/DefaultLogModelProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/us/ihmc/multicastLogDataProtocol/modelLoaders/DefaultLogModelProvider.java
Show resolved
Hide resolved
| @@ -52,8 +60,7 @@ public byte[] getResourceZip() | |||
| ByteArrayOutputStream os = new ByteArrayOutputStream(); | |||
| try | |||
| { | |||
| Pattern zipExclude = null; //Pattern.compile(".*\\.(?i)(zip)$"); | |||
| ClassLoaderTools.createZipBundle(os, zipExclude, resourceDirectories); | |||
| ResourceLoaderTools.createZipBundle(os, filter, topLevelResourceDirectories); | |||
There was a problem hiding this comment.
Pass down the filter here
|
I'd also like to squash these commits before its merged, several of these commits are useless. @SylvainBertrand I know you are trying that with SCS2, you cool if I do that here? |
SylvainBertrand
approved these changes
Feb 29, 2024
PotatoPeeler3000
added
good first issue
|
Closing pull request with comment, checking out how this feature works... |
|
I guess you don't want to close the PR. You want to merge it, oops |
|
I think because I force pushed, it wouldn't let me merge this PR, interesting, need to play with that next time. The new PR with the squashed commits is here: #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also learning how to use GitHub with this PR...