Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: added horizontal bar chart #160

Closed
wants to merge 1 commit into from

Conversation

j4nk3e
Copy link
Contributor

@j4nk3e j4nk3e commented Jan 9, 2020

Added horizontal bar charts.

To be able to reuse the bar_chart_data, I changed the naming of y and x to in the bars and groups to value, because in the horizontal bar they would be flipped.
Also, horizontal bars have the ability to put text onto the bar, which is saved in BarChartRodData.title.
We could also draw this text 90° rotated on the vertical bar chart to be consistent, but this is not implemented yet.

I added a temporary example here

What do you think?

PS: it would be really cool if we could format the code according to effective dart, I just noticed there is a lot of whitespace change in the diff which is unrelated :(

@imaNNeo
Copy link
Owner

imaNNeo commented Jan 9, 2020

Wow, there are a lot of changes.
I'm so happy to see that, it fixes #113
I will review it ASAP, give me some time dude :)
And about the code format, I'm totally with you but do not reformat in a feature PR ever, it makes the review process hard,
make a new PR, and do all reformat in that, I will merge it ASAP.
Thanks!

@scostagabriel
Copy link

scostagabriel commented Mar 7, 2020

@imaNNeoFighT , thank you for this amazing library, it's really awesome! Thank you also @juumixx for this PR.

Do you have any expectations about when to merge this PR? I've tried to implement these classes but I think it isn't working anymore due to updates of the library.

@imaNNeo imaNNeo closed this Mar 14, 2020
@berengere13
Copy link

Hello,

Have you any news about this feature ? Our team is very interested !

Thanks you very much.

@imaNNeo
Copy link
Owner

imaNNeo commented Mar 23, 2020

Hello, I think it's not gonna implement soon,
because we are so busy, can make your hands dirty and try to implement it.
Thanks, regards!

@Nazacheres
Copy link

@imaNNeoFighT Actually similar results can be achieved, just by wrapping BarChart with RotatedBox. What would be good is just enable rotation for titles and tooltips :) That's a small change.

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 23, 2020

Okay, make separate issues for them to follow up.
Thanks for suggesting!

@liasica
Copy link

liasica commented Jan 17, 2021

@imaNNeoFighT Actually similar results can be achieved, just by wrapping BarChart with RotatedBox. What would be good is just enable rotation for titles and tooltips :) That's a small change.

tooltips rotation how?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants