Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail (Delta-V Port) #1333

Merged
merged 32 commits into from
Jan 16, 2025
Merged

Mail (Delta-V Port) #1333

merged 32 commits into from
Jan 16, 2025

Conversation

honeyed-lemons
Copy link

@honeyed-lemons honeyed-lemons commented Jan 13, 2025

Ports the Mail system from delta-v, including a new Courier job in cargo.

This is a BIG PR with lots of things to do, so heres a full todo list :D :D :D

  • Courier Job

    • Implement new job type
    • Implement courierdrobe
    • Add new access type for Couriers
    • Add new Door type for couriers
  • Mail

    • Cherrypick Delta-V and frontier mail to port over
  • Resprites

    • Mail Item
    • Mail Package Item
    • Mail Teleporter

Changelog

🆑 Honeyed_Lemons_, AftrLite

  • add: Added the Courier Job, a new role that delivers packages and letters to people!
  • add: Mapped Courier to Xeno and Box

@Darkmajia
Copy link

how do mail contents work on delta v? i could be dreaming of features that already exist but i think it'd be cute if jobs and traits factored into a character's potential mail pool. i yearn for hos players to get more pills in the post

@honeyed-lemons
Copy link
Author

how do mail contents work on delta v? i could be dreaming of features that already exist but i think it'd be cute if jobs and traits factored into a character's potential mail pool. i yearn for hos players to get more pills in the post

Certain jobs can have certain mails weighted more for them, so HoS can get pills sent to them more often!

@AftrLite
Copy link

I am very invested in this.

@kipdotnet
Copy link

I am very invested in this.

Is it because three quarters of it needs respriting

@Lyndomen
Copy link

Traits have no weight right now, but jobs and departments do.

@whatston3
Copy link

Neat. Hope it works out!

@kipdotnet
Copy link

#1357
Made a contribution to the mail effort

@AftrLite AftrLite self-assigned this Jan 14, 2025
@AftrLite
Copy link

Good work on porting the Mail_Large spritelayers (fragile, priority, ect) to the small mail sprite 👍

# Conflicts:
#	Resources/Prototypes/Entities/Objects/Devices/pda.yml
#	Resources/Prototypes/Entities/Stations/nanotrasen.yml
#	Resources/Prototypes/_DV/Entities/Objects/Devices/cartridges.yml
#	Resources/Prototypes/_Impstation/Loadouts/loadout_groups.yml
@kipdotnet kipdotnet mentioned this pull request Jan 15, 2025
@honeyed-lemons honeyed-lemons marked this pull request as ready for review January 15, 2025 18:18
@honeyed-lemons
Copy link
Author

IT IS DONE

@kipdotnet
Copy link

Could you add AftrLite to the changelog? You just write what names you want next to the cl emoji

@honeyed-lemons
Copy link
Author

done! now we wait for review

@kipdotnet
Copy link

Ill check it when I get home, should be about 7 hours from now

Copy link

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't even looked at yaml (because GitHub would probably die and I can't review from an IDE) but I assume it's probably bad too, so just make sure it at least follows the correct entity prototype order.
Ping me in the Discord if you have any questions.

Content.Client/_DV/Mail/MailComponent.cs Outdated Show resolved Hide resolved
Content.Client/_DV/Mail/MailSystem.cs Outdated Show resolved Hide resolved
Content.Client/_DV/Mail/MailSystem.cs Outdated Show resolved Hide resolved
Content.Shared/_DV/Mail/MailVisuals.cs Outdated Show resolved Hide resolved
Copy link

@kipdotnet kipdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine, linter hasnt exploded, map didnt explode. sending it

@kipdotnet kipdotnet merged commit 8ddb817 into impstation:master Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.