Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-ro lobby screen #1397

Closed
wants to merge 10 commits into from
Closed

Conversation

Sha-Seng
Copy link

@Sha-Seng Sha-Seng commented Jan 17, 2025

smiles so sweetly

NO-RO 1

🆑

  • add: No-Ro lobby art
  • remove: Kaasi lobby art (there's only one chair)

…4-morepillz"

This reverts commit 3c143b3, reversing
changes made to 3c2e781.
@Sha-Seng Sha-Seng marked this pull request as draft January 17, 2025 01:30
@mqole
Copy link

mqole commented Jan 17, 2025

not to be evil and mean with it but im hesitant to allow players to have multiple lobby screens of Just Their Character lest we be accused of favouritism (esp since theyre both commissions as opposed to art done by members of the playerbase)

would love anyone with opinions on this to weigh in too

sorry im noticing a story being told through these commits and it is giving me a sensible chuckle

@Sha-Seng Sha-Seng marked this pull request as ready for review January 17, 2025 01:38
Copy link

@hivehum hivehum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an attribution

@Sha-Seng Sha-Seng requested a review from hivehum January 17, 2025 01:42
@hivehum
Copy link

hivehum commented Jan 17, 2025

also yeah i dont really love people purchasing art of their characters and then trying to put it into the game. it feels kind of ego stoking. every other instance of lobby art has been people posting art that has then later been adapted into lobby art. additionally until just now i had literally 0 idea who made either this or the kaasi art because you never posted attributions.

@hivehum hivehum dismissed their stale review January 17, 2025 01:54

requests met but i dont want to approve until more discussion

@Sha-Seng
Copy link
Author

i'm not sure how people feel about it overall, but to cover my ass here i didn't pr this or the kaasi one before other people requested it be lobby art

i wasn't even aware there were attributions back when i made the kaasi one (it was a long time ago), and the artist's main twitter is full of porn so i don't link it - rather, i asked them to sign both pieces including their social handle so it could be found that way, which should be fine since our server is 20+

it feels kind of ego stoking

why would i have an ego about something i didn't make? it just makes me innocently happy to see my character and gets people excited about cool art

@hivehum
Copy link

hivehum commented Jan 17, 2025

why would i have an ego about something i didn't make? it just makes me innocently happy to see my character and gets people excited about cool art

because you paid money for someone else to make something that is completely perfectly set up to be lobby art, posted it to discord, waited for 1 person to go "wow this should be lobby art" and then did the thing it honestly seems like you were already planning

@mqole
Copy link

mqole commented Jan 17, 2025

alright centcomm hath discussed

having this be a commission of Just Your Character is the main sticking point. if this was a group pic or something it would be less of an issue. but its also kind of against what the server stands for to have art in the game by someone who was paid to add art to the game, rather than art that has naturally spawned from our community

if you wanna add this we can, but we'll have to get rid of the kaasi splashscreen. up to you which one you wanna keep
EDIT: oh and i think the kaasi splashscreen needs fixed attributions unless you got that already
EDIT 2: i am capable of reading code i promise (you have in fact got that already)

@Sha-Seng
Copy link
Author

Sha-Seng commented Jan 17, 2025

because you paid money for someone else to make something that is completely perfectly set up to be lobby art, posted it to discord, waited for 1 person to go "wow this should be lobby art" and then did the thing it honestly seems like you were already planning

when i commissioned the kaasi art i did it in that format just in case it would be acceptable lobby art. i wanted the art anyway (pixel games leave too much to the imagination) but if it got in as a splash screen, well, cool. it's a bonus if not only i enjoy the art, but other people do as well. it's the same thing here. and it's much better than having to expand the art after the fact

paying for art with money i earned isn't a moral failure, and neither is having happy aspirations that people will like my funny characters and i'll feel welcome in a community. you're painting me as some kind of manipulative attention seeker

if you wanna add this we can, but we'll have to get rid of the kaasi splashscreen. up to you which one you wanna keep

i'd be okay with doing this

and also fwiw i understand the reasoning, it was just harshly phrased

@Sha-Seng Sha-Seng marked this pull request as draft January 17, 2025 02:35
@Sha-Seng Sha-Seng marked this pull request as ready for review January 17, 2025 05:22
@mqole
Copy link

mqole commented Jan 17, 2025

image
the evil brancherrrrrrr (i'll fix lol)

@Sha-Seng
Copy link
Author

god almighty.

@mqole
Copy link

mqole commented Jan 17, 2025

actually can i ask you to remove the kaasi files and attributions wholecloth? keeping them in feels like unnecessary bloat if we're removing them anyway

@mqole
Copy link

mqole commented Jan 17, 2025

linter failing feels like the cherry on top to all those commits

look, i'll just close this and make a new pr for it with the changes lmao. go to bed

@mqole mqole closed this Jan 17, 2025
@Sha-Seng
Copy link
Author

hell on earth because the vests got merged first (yay though)

thank you for the help zzzzz

@mqole mqole mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants