Correctly implement the code_change callback

inaka · Aug 12, 2024 · 2de0ac5 · 2de0ac5
1 parent c2295c5
commit 2de0ac5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/wpool_process.erl b/src/wpool_process.erl
@@ -170,14 +170,15 @@ terminate(Reason, State) ->
     end.
 
 %% @private
--spec code_change(string(), state(), any()) -> {ok, state()} | {error, term()}.
+-spec code_change(string() | {down, string()}, state(), any()) ->
+                     {ok, state()} | {error, term()}.
 code_change(OldVsn, #state{mod = #callback_cache{module = Mod}} = State, Extra) ->
     case erlang:function_exported(Mod, code_change, 3) of
         true ->
             case Mod:code_change(OldVsn, State#state.state, Extra) of
                 {ok, NewState} ->
                     {ok, State#state{state = NewState}};
-                Error ->
+                {error, Error} ->
                     {error, Error}
             end;
         _ ->

diff --git a/test/wpool_process_SUITE.erl b/test/wpool_process_SUITE.erl
@@ -334,7 +334,7 @@ complete_coverage(_Config) ->
     ct:comment("Code Change"),
     {ok, State} = wpool_process:init({complete_coverage, echo_server, {ok, state}, []}),
     {ok, _} = wpool_process:code_change("oldvsn", State, {ok, state}),
-    {error, bad} = wpool_process:code_change("oldvsn", State, bad),
+    {error, bad} = wpool_process:code_change("oldvsn", State, {error, bad}),
 
     {comment, []}.