Get rid of the worker_type option #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 10 10
Lines 456 456
=======================================
Hits 422 422
Misses 34 34 ☔ View full report in Codecov by Sentry. |
Closed
paulo-ferraz-oliveira
approved these changes
Dec 16, 2023
elbrujohalcon
approved these changes
Dec 19, 2023
|
I'm not sure why tests fail after merging this branch with |
I've seen |
We're not planning to implement support for anything other than gen_servers any time soon.
NelsonVides
force-pushed
the
get_rid_of_worker_type
branch
from
5337c05 to
1a7f23f
Compare
|
There, just a retry and this is green, we've got a flaky test @elbrujohalcon 🤷🏽 |
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not planning to implement support for anything other than gen_servers any time soon.
Tackles #194.