-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework documentation #200
Merged
Merged
Rework documentation #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Dec 19, 2023
NelsonVides
force-pushed
the
rework_documentation
branch
from
December 19, 2023 08:54
781ba4a
to
305d113
Compare
NelsonVides
force-pushed
the
rework_documentation
branch
from
December 19, 2023 16:52
305d113
to
0589755
Compare
elbrujohalcon
requested changes
Dec 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 92.54% 92.57% +0.03%
==========================================
Files 10 10
Lines 456 458 +2
==========================================
+ Hits 422 424 +2
Misses 34 34 ☔ View full report in Codecov by Sentry. |
elbrujohalcon
approved these changes
Dec 21, 2023
Lovely to see this merged! Wanna publish a new package @elbrujohalcon to have the docs public? 😁 |
Done already. https://hexdocs.pm/worker_pool/readme.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from this threat in the Erlang Forums, I thought of entirely reworking the documentation. I was never really a big fan of that large README file with everything, never found it much readable and most of my knowledge of the library really came from how we use it in MongooseIM. So I decided to split that big readme and move most of it to the respective types and function definitions defined in the
wpool
module, taking care of all the links working right. That also puts documentation next to the code, which might be easier to maintain in the future.The best way to review this would be to build docs locally with
rebar3 ex_doc
and browse :)I also added a function that creates the child-spec directly, so that it can be added to a supervision tree.
It is on top of the commit added to #198 for convenience for me mostly, so merging that one first would be best :)
Now, for the documentation to build correctly and display all the information in the defined types, we really need to let
rebar3_format
allow comments directly below types, as this is howex_doc
builds docs for types :|