Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Erlang/OTP 27 #205

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Adopt Erlang/OTP 27 #205

merged 2 commits into from
Jul 10, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Closes #204.

elbrujohalcon
elbrujohalcon requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just move us through to OTP27 and set the min_otp_vsn param appropriately on rebar.config instead of using -if(…).s.
Thanks.

src/wpool_process.erl Outdated Show resolved Hide resolved
@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 0ec5ee5 into main Jul 10, 2024
1 check passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the chore/adopt-otp-27 branch July 10, 2024 17:43
@paulo-ferraz-oliveira
Copy link
Collaborator Author

I'll release a version.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Can't publish to Hex.pm. No prob. The GitHub release is done, though.

@elbrujohalcon
Copy link
Member

https://hex.pm/packages/worker_pool/6.2.1

@arcusfelis arcusfelis mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warnings_as_errors is bad
2 participants
@paulo-ferraz-oliveira @elbrujohalcon