Fix check for redundant loop priority #895
Conversation
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
kaushikcfd
force-pushed
the
fix_loop_prio
branch
from
8e2656d to
7d4adfb
Compare
| @@ -862,10 +863,14 @@ def _update_nesting_constraints( | |||
| .ancestors(inner_iname_nest)) | |||
| ancestors_of_outer_iname = (loop_nest_tree | |||
| .ancestors(outer_iname_nest)) | |||
| if outer_iname in ancestors_of_inner_iname: | |||
There was a problem hiding this comment.
Would have been nice if mypy could tell us our comparison types are incompatible. We were checking "InameStr in tuple[InameStrSet, ...]" which would always return False.
There was a problem hiding this comment.
I agree. But __contains__ is typed for object: https://github.com/python/typeshed/blob/d70fad09dd7012bd43304e1c67b7599558b90c39/stdlib/typing.pyi#L575
😢
To their credit, the Python types people have discussed it: python/typeshed#8219
|
Thanks! |
| @@ -862,10 +863,14 @@ def _update_nesting_constraints( | |||
| .ancestors(inner_iname_nest)) | |||
| ancestors_of_outer_iname = (loop_nest_tree | |||
| .ancestors(outer_iname_nest)) | |||
| if outer_iname in ancestors_of_inner_iname: | |||
There was a problem hiding this comment.
I agree. But __contains__ is typed for object: https://github.com/python/typeshed/blob/d70fad09dd7012bd43304e1c67b7599558b90c39/stdlib/typing.pyi#L575
😢
To their credit, the Python types people have discussed it: python/typeshed#8219
|
FYI: Firedrake failures are expected for the time being, see #894. |
inducer
force-pushed
the
fix_loop_prio
branch
from
7d4adfb to
6151bd3
Compare
inducer
force-pushed
the
fix_loop_prio
branch
from
6151bd3 to
ffe77c3
Compare
Closes #890.
The attached regression fails on
main./cc @connorjward