feat: Add message history truncation #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjcsmith
force-pushed
the
351-message-history-truncation
branch
from
820a8cf to
1e84d5c
Compare
johnjcsmith
force-pushed
the
351-message-history-truncation
branch
4 times, most recently
from
c0b6d1a to
92d9d57
Compare
johnjcsmith
commented
Dec 23, 2024
johnjcsmith
force-pushed
the
351-message-history-truncation
branch
4 times, most recently
from
e8593c5 to
99b295b
Compare
johnjcsmith
force-pushed
the
351-message-history-truncation
branch
from
99b295b to
f3b7487
Compare
nadeesha
approved these changes
Dec 25, 2024
johnjcsmith
added a commit
that referenced
this pull request
Dec 26, 2024
This reverts commit 2489bf7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
handleContextWindowOverflowwhich truncates the chat history to ensure that it fits within the models context window.This will work through the message history removing the oldest message until it is within the context window and ensures that the history remains valid:
agentmessage's subsequent invocation resultshumanmessageThis only works on the messages that are fetched from the database (currently last 100).
It should be a final guard to make sure what we are sending the model is not going to overflow.
Ideally we will also implement some history summarisation.