feat: add options to pass a repo path, and to handle lightweight tags #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
reviewed
Aug 11, 2021
| @@ -109,6 +113,7 @@ func createRelease(r *git.Repository, verTag string) (*Release, error) { | |||
| func findVersionHash(r *git.Repository, verTag string) (plumbing.Hash, error) { | |||
| if verTag == "" { | |||
| ref, err := r.Head() | |||
| //log.Printf(ref.String()) | |||
|
LGTM other than the commented code but not sure who else should review |
|
Looks from the merge history like @wolffcm or @jsternberg should have a look. |
lesam
reviewed
Aug 12, 2021
| if !lightweightOK { | ||
| return nil, plumbing.ZeroHash, errors.Wrap(err, "could not get tag object from maxRef") | ||
| } else { | ||
| return maxVersion, maxRef.Hash(), nil |
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you elaborate a bit more? I'm not quite sure what you're asking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10 and #5.
Also adds an option to pass an absolute path to the CLI, which makes running this tool easier under a variety of conditions.