Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating API write endpoint #5776

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peterbarnett03
Copy link
Collaborator

Closes #5775

Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this not break backward compatibility?

@jstirnaman jstirnaman self-requested a review January 15, 2025 10:11
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassed that I got sidetracked and didn't finish testing all these. Gotta update the test harness.

Comment on lines +161 to +162
* `/write_lp?db=mydb,precision=ns`
* `/api/v2/write_lp?db=mydb,precision=ns`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `/write_lp?db=mydb,precision=ns`
* `/api/v2/write_lp?db=mydb,precision=ns`
* `/write?db=mydb,precision=ns`
* `/api/v2/write?db=mydb,precision=ns`

Comment on lines +159 to +160
* `/write_lp?db=mydb,precision=ns`
* `/api/v2/write_lp?db=mydb,precision=ns`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `/write_lp?db=mydb,precision=ns`
* `/api/v2/write_lp?db=mydb,precision=ns`
* `/write?db=mydb,precision=ns`
* `/api/v2/write?db=mydb,precision=ns`


{{% product-name %}} provides the `/write` and `/api/v2` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.
{{% product-name %}} provides the `/write_lp` and `/api/v2` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.
Copy link
Contributor

@jstirnaman jstirnaman Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% product-name %}} provides the `/write_lp` and `/api/v2` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.
{{% product-name %}} provides the `/write` and `/api/v2/write` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.

content/shared/v3-core-get-started/_index.md Show resolved Hide resolved

{{% product-name %}} provides the `/write` and `/api/v2` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.
{{% product-name %}} provides the `/write_lp` and `/api/v2` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.
Copy link
Contributor

@jstirnaman jstirnaman Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% product-name %}} provides the `/write_lp` and `/api/v2` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.
{{% product-name %}} provides the `/write` and `/api/v2/write` endpoints for backward compatibility with clients that can write data to previous versions of InfluxDB.

This was referenced Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix API v3 endpoint in "Getting started docs"
2 participants