Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup workspace-hack config so hakari works #16

Merged
merged 1 commit into from
Apr 23, 2024
Merged

chore: setup workspace-hack config so hakari works #16

merged 1 commit into from
Apr 23, 2024

Conversation

hiltontj
Copy link
Collaborator

Added the .config/hakari.toml file from IOx, and then ran cargo hakari generate. Having this in working order will be necessary for setting up CI, see #5

@hiltontj hiltontj requested a review from mgattozzi April 23, 2024 13:43
@hiltontj hiltontj self-assigned this Apr 23, 2024
mgattozzi
mgattozzi reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mgattozzi mgattozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that when I split out core I had some issues with the cargo workspace in the OSS repo. I think it was just that we couldn't use the hack here and in OSS. Do you mind testing the OSS repo with these changes included before I approve it?

@hiltontj
Copy link
Collaborator Author

Do you mind testing the OSS repo with these changes included before I approve it?

Good call, I will open a test PR in influxdb

@hiltontj hiltontj mentioned this pull request Apr 23, 2024
Merged
@hiltontj
Copy link
Collaborator Author

@mgattozzi - I opened influxdata/influxdb#24937 to run CI using this branch and looks ✅

mgattozzi
mgattozzi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mgattozzi mgattozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great let's get it in!

@hiltontj hiltontj merged commit b546e7f into main Apr 23, 2024
@hiltontj hiltontj deleted the hiltontj/hakari branch April 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgattozzi mgattozzi mgattozzi approved these changes

Assignees

@hiltontj hiltontj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiltontj @mgattozzi