refactor: Extract pieces to make them more testable #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
force-pushed
the
cn/testability
branch
2 times, most recently
from
13c54c2 to
d79197d
Compare
crepererum
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
I like it and I think it's the way to go. I guess we need to improve the interface / trait documentation over time. Let's not get this PR too big. If you're happy with the names and docs, I think you can already merge it and start a new one with a new series of patches.
tustvold
approved these changes
Jan 17, 2022
carols10cents
force-pushed
the
cn/testability
branch
from
3e6c35c to
ade4aa3
Compare
carols10cents
force-pushed
the
cn/testability
branch
from
ade4aa3 to
553460a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #49 .
This set of commits attempts to refactor some of the retry code to allow for mocking and unit testing, as well as some code reuse. I highly recommend reviewing commit-by-commit.
Names of the extracted methods are Friday-afternoon quality and should be changed to whatever everyone likes, assuming that you like the direction of these refactorings.
There's absolutely more that can be done here, but this is as far as Jake and I got today. Do you like this? 🥺 👉🏻 👈🏻