Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inputs.sql): Add protocol to DSN #16330

Merged
merged 2 commits into from
Jan 16, 2025
Merged

docs(inputs.sql): Add protocol to DSN #16330

merged 2 commits into from
Jan 16, 2025

Conversation

midlan
Copy link
Contributor

@midlan midlan commented Dec 18, 2024

Summary

For some reason telegraf was not working for sql input until i added tcp(...) parenthesis to dsn.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@srebhan
Copy link
Member

srebhan commented Dec 18, 2024

@midlan thanks for your contribution! Please sign the CLA so we can start reviewing your PR!

@srebhan srebhan self-assigned this Dec 18, 2024
@srebhan
Copy link
Member

srebhan commented Dec 19, 2024

!signed-cla

1 similar comment
@midlan
Copy link
Contributor Author

midlan commented Dec 19, 2024

!signed-cla

@srebhan srebhan changed the title README sql input config dsn fix docs(inputs.sql): Add protocol to DSN Dec 20, 2024
@telegraf-tiger telegraf-tiger bot added area/sql docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 20, 2024
@srebhan
Copy link
Member

srebhan commented Dec 20, 2024

@midlan you need to also make this change to sample.conf (and run make docs) as we enforce both README.md and sample.conf to be in sync... Otherwise the change looks good.

srebhan
srebhan approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @midlan for your contribution! I took the liberty to fix the PR according to my comment... Hope that's okay for you!?

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 15, 2025
@srebhan
Copy link
Member

srebhan commented Jan 15, 2025

Test failures are not related to this change.

@srebhan srebhan assigned DStrand1 and unassigned srebhan Jan 15, 2025
@DStrand1 DStrand1 merged commit 237dd3d into influxdata:master Jan 16, 2025
9 of 13 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/sql docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.2
Development

Successfully merging this pull request may close these issues.
3 participants
@midlan @srebhan @DStrand1