fix(inputs.opcua): Auto fan out array nodes into individual fields #16359
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/opcua
fix
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Thanks for your fix @inhinias! I do have one comment in the code. Furthermore, I wonder if we can get rid of the reflection in here and do explicit type assertions?
Could you also please provide a unit-test so we don't run into this again?
Comment on lines
+434
to
+442
| valueArray := unpackArray(o.LastReceivedData[nodeIdx].Value) | ||
| if len(valueArray) == int(o.LastReceivedData[nodeIdx].ArrayLength) { | ||
| for index, value := range valueArray { | ||
| var sb strings.Builder | ||
| sb.WriteString(nmm.Tag.FieldName) | ||
| sb.WriteString(strconv.Itoa(int(index))) | ||
| fields[sb.String()] = value | ||
| } | ||
| } |
There was a problem hiding this comment.
How about folding the unpackArray function into here and reuse its for loop? This saves both allocations and loop iterations...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reading an entire OPC-UA array results in the metric creation to fail silently and reading an individual array element result in a bad node ID.
This PR detects an array and fans it out. So a read array results in each index being collected as a separate metric e.g: MetricName + Index.
This is just a simple way to get it to work. Maybe there is a way to store entire array as a metric, but I'm not all too familiar with the codebase as a whole. Options welcome.
Also Note:
Checklist
Related issues
resolves #11898